Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize: rename zk configuration root path. #1994

Merged
merged 6 commits into from
Dec 9, 2019
Merged

optimize: rename zk configuration root path. #1994

merged 6 commits into from
Dec 9, 2019

Conversation

objcoding
Copy link
Contributor

@objcoding objcoding commented Dec 5, 2019 •
edited

Ⅰ. Describe what this PR did

There are many projects for 'config' node in zk, such as kafka.

xingfudeshi
xingfudeshi approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi self-requested a review December 6, 2019 06:09
@xingfudeshi xingfudeshi self-requested a review December 6, 2019 06:11
xingfudeshi
xingfudeshi requested changes Dec 6, 2019
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some places need to be changed too.

@objcoding objcoding changed the title optimize: It is recommended to change 'config' to 'seata' to avoid conflict. optimize: fix zk root path. Dec 6, 2019
@objcoding
Copy link
Contributor Author

There are some places need to be changed too.

Has been modified

@codecov-io
Copy link

codecov-io commented Dec 6, 2019 •
edited

Codecov Report

Merging #1994 into develop will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #1994      +/-   ##
============================================
+ Coverage      55.26%   55.3%   +0.04%     
- Complexity      2430    2432       +2     
============================================
  Files            432     432              
  Lines          14439   14439              
  Branches        1706    1706              
============================================
+ Hits            7980    7986       +6     
+ Misses          5735    5732       -3     
+ Partials         724     721       -3
Impacted Files Coverage Δ Complexity Δ
...o/seata/server/coordinator/DefaultCoordinator.java 48.41% <0%> (+0.39%) 28% <0%> (+1%) ⬆️
...in/java/io/seata/server/session/GlobalSession.java 85.02% <0%> (+0.48%) 68% <0%> (+1%) ⬆️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 63.7% <0%> (+0.8%) 24% <0%> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 57.46% <0%> (+0.95%) 29% <0%> (ø) ⬇️

@zjinlei zjinlei changed the title optimize: fix zk root path. optimize: rename zk root path. Dec 7, 2019
@zjinlei zjinlei changed the title optimize: rename zk root path. optimize: rename zk configuration root path. Dec 7, 2019
zjinlei
zjinlei approved these changes Dec 7, 2019
View reviewed changes
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei added this to the 1.0 milestone Dec 8, 2019
xingfudeshi
xingfudeshi approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zjinlei zjinlei merged commit fce5e8f into apache:develop Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjinlei zjinlei zjinlei approved these changes

@xingfudeshi xingfudeshi xingfudeshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@objcoding @codecov-io @zjinlei @xingfudeshi