Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:fix auto proxying of datasource which has final modifier #1996

Merged
merged 6 commits into from
Dec 10, 2019
Merged

bugfix:fix auto proxying of datasource which has final modifier #1996

merged 6 commits into from
Dec 10, 2019

Conversation

xingfudeshi
Copy link
Member

@xingfudeshi xingfudeshi commented Dec 6, 2019

Ⅰ. Describe what this PR did

When enable auto proxying of datasouce which has final modifier,it will cause a Exception means the class can't be proxied by using cglib.This PR will use JDK proxy instead of cglib to avoid this problem.

Ⅱ. Does this pull request fix one issue?

fixes #1995

Ⅲ. Why don't you add test cases (unit test/integration test)?

I've done integration testing with following scenes:
1.Specific init-method for a datasource bean defination.
2.A datasource class that with final modifier.
3.A datasource that extends AbstractRoutingDataSource.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Dec 6, 2019

Codecov Report

Merging #1996 into develop will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1996      +/-   ##
=============================================
+ Coverage      55.25%   55.26%   +0.01%     
- Complexity      2430     2432       +2     
=============================================
  Files            432      432              
  Lines          14439    14442       +3     
  Branches        1706     1706              
=============================================
+ Hits            7978     7982       +4     
- Misses          5736     5738       +2     
+ Partials         725      722       -3
Impacted Files Coverage Δ Complexity Δ
...ta/spring/annotation/GlobalTransactionScanner.java 48.67% <0%> (-1.33%) 17 <0> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 48.41% <0%> (+0.39%) 28% <0%> (+1%) ⬆️
...in/java/io/seata/server/session/GlobalSession.java 85.02% <0%> (+0.48%) 68% <0%> (+1%) ⬆️
...server/store/file/FileTransactionStoreManager.java 56.5% <0%> (+0.63%) 29% <0%> (ø) ⬇️

@xingfudeshi xingfudeshi changed the title bugfix:fix auto proxying of datasource which has final modifier WIP:bugfix:fix auto proxying of datasource which has final modifier Dec 6, 2019
@xingfudeshi xingfudeshi closed this Dec 6, 2019
@xingfudeshi xingfudeshi reopened this Dec 6, 2019
@xingfudeshi xingfudeshi changed the title WIP:bugfix:fix auto proxying of datasource which has final modifier bugfix:fix auto proxying of datasource which has final modifier Dec 6, 2019
@zjinlei zjinlei added this to the 1.0 milestone Dec 8, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsbxyyx jsbxyyx merged commit a036cb8 into apache:develop Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

problem about auto proxying of datasource which has final modifier
5 participants