Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: replace deprecated jvm args #2001

Merged
merged 2 commits into from
Dec 9, 2019
Merged

bugfix: replace deprecated jvm args #2001

merged 2 commits into from
Dec 9, 2019

Conversation

helloworlde
Copy link
Contributor

@helloworlde helloworlde commented Dec 7, 2019

Ⅰ. Describe what this PR did

  1. replace deprecated jvm args

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Dec 7, 2019

Codecov Report

Merging #2001 into develop will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2001      +/-   ##
=============================================
+ Coverage      55.26%   55.32%   +0.06%     
- Complexity      2429     2433       +4     
=============================================
  Files            432      432              
  Lines          14439    14439              
  Branches        1706     1706              
=============================================
+ Hits            7979     7988       +9     
+ Misses          5735     5731       -4     
+ Partials         725      720       -5
Impacted Files Coverage Δ Complexity Δ
...o/seata/server/coordinator/DefaultCoordinator.java 48.41% <0%> (+0.39%) 28% <0%> (+1%) ⬆️
...in/java/io/seata/server/session/GlobalSession.java 85.02% <0%> (+0.48%) 68% <0%> (+1%) ⬆️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 63.7% <0%> (+0.8%) 24% <0%> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 58.09% <0%> (+1.58%) 30% <0%> (+1%) ⬆️
...ource/sql/struct/cache/AbstractTableMetaCache.java 88.23% <0%> (+2.94%) 12% <0%> (+1%) ⬆️

@zjinlei zjinlei added this to the 1.0 milestone Dec 8, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit f9c3524 into apache:develop Dec 9, 2019
@helloworlde helloworlde deleted the bugfix_args branch December 9, 2019 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants