Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:fix seata-spring-boot-starter does not work #2029

Merged
merged 5 commits into from
Dec 16, 2019
Merged

bugfix:fix seata-spring-boot-starter does not work #2029

merged 5 commits into from
Dec 16, 2019

Conversation

xingfudeshi
Copy link
Member

Ⅰ. Describe what this PR did

fix seata-spring-boot-starter does not work.

Ⅱ. Does this pull request fix one issue?

fixes #2027

Ⅲ. Why don't you add test cases (unit test/integration test)?

I've done integration testing.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Dec 13, 2019

Codecov Report

Merging #2029 into develop will decrease coverage by 0.07%.
The diff coverage is 26.08%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2029      +/-   ##
=============================================
- Coverage      55.03%   54.95%   -0.08%     
+ Complexity      2475     2472       -3     
=============================================
  Files            444      444              
  Lines          14794    14809      +15     
  Branches        1746     1749       +3     
=============================================
- Hits            8142     8139       -3     
- Misses          5907     5920      +13     
- Partials         745      750       +5
Impacted Files Coverage Δ Complexity Δ
...c/main/java/io/seata/config/FileConfiguration.java 36.79% <26.08%> (-4.11%) 6 <1> (ø)
...server/store/file/FileTransactionStoreManager.java 56.5% <0%> (-0.64%) 29% <0%> (-1%)
...in/java/io/seata/server/session/GlobalSession.java 84.54% <0%> (-0.49%) 67% <0%> (-1%)
...o/seata/server/coordinator/DefaultCoordinator.java 48.01% <0%> (-0.4%) 27% <0%> (-1%)

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei added this to the 1.0 milestone Dec 14, 2019
@zjinlei
Copy link
Contributor

zjinlei commented Dec 14, 2019

retry ci

@zjinlei zjinlei closed this Dec 14, 2019
@zjinlei zjinlei reopened this Dec 14, 2019
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 23b4a77 into apache:develop Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.0版使用yml配置时启动异常
6 participants