Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix Etcd3Configuration FILE_CONFIG reference incorrect. #2032

Merged
merged 2 commits into from
Dec 13, 2019

Conversation

objcoding
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

objcoding and others added 2 commits December 13, 2019 21:31
@objcoding objcoding changed the title bugfix: Etcd3Configuration FILE_CONFIG Filed should be ConfigurationFactory.CURRENT_FILE_INSTANCE instead of ConfigurationFactory.getInstance() bugfix: fix Etcd3Configuration FILE_CONFIG. Dec 13, 2019
@objcoding objcoding changed the title bugfix: fix Etcd3Configuration FILE_CONFIG. bugfix: Modify the value of Etcd3Configuration FILE_CONFIG. Dec 13, 2019
@zjinlei zjinlei changed the title bugfix: Modify the value of Etcd3Configuration FILE_CONFIG. bugfix: fix Etcd3Configuration FILE_CONFIG reference incorrect. Dec 13, 2019
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #2032 into develop will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2032      +/-   ##
=============================================
+ Coverage      54.83%   55.03%   +0.19%     
- Complexity      2472     2474       +2     
=============================================
  Files            444      444              
  Lines          14774    14793      +19     
  Branches        1707     1746      +39     
=============================================
+ Hits            8102     8141      +39     
- Misses          5902     5907       +5     
+ Partials         770      745      -25
Impacted Files Coverage Δ Complexity Δ
...java/io/seata/spring/tcc/TccActionInterceptor.java 12.5% <0%> (-0.33%) 2% <0%> (ø)
...n/java/io/seata/rm/datasource/ConnectionProxy.java 25.83% <0%> (-0.22%) 12% <0%> (ø)
...a/io/seata/core/rpc/netty/AbstractRpcRemoting.java 9.64% <0%> (-0.2%) 3% <0%> (ø)
...ing/annotation/GlobalTransactionalInterceptor.java 10% <0%> (-0.15%) 2% <0%> (ø)
...in/java/io/seata/server/session/GlobalSession.java 85.02% <0%> (-0.13%) 68% <0%> (+1%)
...in/java/io/seata/server/session/BranchSession.java 80.45% <0%> (-0.02%) 44% <0%> (ø)
...va/io/seata/core/store/db/LogStoreDataBaseDAO.java 55.44% <0%> (+0.14%) 21% <0%> (ø) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 48.41% <0%> (+0.39%) 28% <0%> (+1%) ⬆️
...server/store/file/FileTransactionStoreManager.java 57.46% <0%> (+0.95%) 29% <0%> (ø) ⬇️
...ain/java/io/seata/config/ConfigurationFactory.java 52% <0%> (+0.97%) 3% <0%> (ø) ⬇️
... and 21 more

@zjinlei zjinlei merged commit 7733dfd into apache:develop Dec 13, 2019
@wangliang181230 wangliang181230 added this to the 1.0.0 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants