-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: optimization for DefaultRemotingParser #2033
Conversation
Replace traversal by value
Codecov Report
@@ Coverage Diff @@
## develop #2033 +/- ##
=============================================
- Coverage 53.06% 52.78% -0.28%
- Complexity 2500 2517 +17
=============================================
Files 485 488 +3
Lines 15303 15342 +39
Branches 1755 1750 -5
=============================================
- Hits 8120 8098 -22
- Misses 6407 6467 +60
- Partials 776 777 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, by recording RemotingParser instance, avoid every call DefaultRemotingParser to iterate over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Replace traversal by value