Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimization for DefaultRemotingParser #2033

Merged
merged 9 commits into from
Feb 5, 2020

Conversation

ph3636
Copy link
Contributor

@ph3636 ph3636 commented Dec 14, 2019

Replace traversal by value

@codecov-io
Copy link

codecov-io commented Dec 14, 2019

Codecov Report

Merging #2033 into develop will decrease coverage by 0.27%.
The diff coverage is 40.06%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2033      +/-   ##
=============================================
- Coverage      53.06%   52.78%   -0.28%     
- Complexity      2500     2517      +17     
=============================================
  Files            485      488       +3     
  Lines          15303    15342      +39     
  Branches        1755     1750       -5     
=============================================
- Hits            8120     8098      -22     
- Misses          6407     6467      +60     
- Partials         776      777       +1
Impacted Files Coverage Δ Complexity Δ
...main/java/io/seata/core/store/db/LogStoreSqls.java 18.86% <ø> (ø) 10 <0> (ø) ⬇️
...in/java/io/seata/server/event/EventBusManager.java 66.66% <ø> (ø) 1 <0> (ø) ⬇️
...gure/provider/SpringBootConfigurationProvider.java 32.3% <0%> (-1.03%) 9 <0> (ø)
.../io/seata/common/loader/EnhancedServiceLoader.java 61.34% <0%> (-2.22%) 25 <0> (ø)
...in/java/io/seata/server/session/SessionHelper.java 64.86% <0%> (-15.14%) 8 <0> (ø)
.../java/io/seata/server/transaction/tcc/TccCore.java 100% <100%> (ø) 2 <2> (?)
...c/main/java/io/seata/config/FileConfiguration.java 36.79% <100%> (ø) 6 <0> (ø) ⬇️
...o/seata/integration/http/AbstractHttpExecutor.java 53.7% <100%> (ø) 10 <0> (ø) ⬇️
.../java/io/seata/core/context/ContextCoreLoader.java 100% <100%> (+42.85%) 1 <1> (ø) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 54.35% <100%> (+4.16%) 28 <0> (-3) ⬇️
... and 27 more

@ph3636 ph3636 changed the title An optimization about DefaultRemotingParser optimize:An optimization about DefaultRemotingParser Dec 14, 2019
@zjinlei zjinlei added this to the 1.1.0 milestone Jan 2, 2020
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, by recording RemotingParser instance, avoid every call DefaultRemotingParser to iterate over.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slievrly slievrly changed the title optimize:An optimization about DefaultRemotingParser optimize: optimization for DefaultRemotingParser Feb 5, 2020
@xingfudeshi xingfudeshi merged commit 9f3d47f into apache:develop Feb 5, 2020
booogu pushed a commit to booogu/seata that referenced this pull request Feb 12, 2020
@ph3636 ph3636 deleted the DefaultRemotingParser branch March 9, 2020 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants