-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix mysql connection unable to release #2037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## develop #2037 +/- ##
============================================
- Coverage 55.01% 55% -0.02%
+ Complexity 2474 2472 -2
============================================
Files 444 444
Lines 14793 14794 +1
Branches 1746 1746
============================================
- Hits 8138 8137 -1
+ Misses 5909 5908 -1
- Partials 746 749 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bugfix: fix mysql connection unable to release (apache#2037)
@a364176773 great found. Does Oracle have the same problem? |
Not yet discovered |
Ⅰ. Describe what this PR did
fix mysql connect unable to release bug
Ⅱ. Does this pull request fix one issue?
fixes #2034
fixes #2035
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews