Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix mysql connection unable to release #2037

Merged
merged 5 commits into from
Dec 14, 2019

Conversation

funky-eyes
Copy link
Contributor

Ⅰ. Describe what this PR did

fix mysql connect unable to release bug

Ⅱ. Does this pull request fix one issue?

fixes #2034
fixes #2035

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@zjinlei zjinlei changed the title fix mysql connect unable to release bug bugfix: fix mysql connection unable to release Dec 14, 2019
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Dec 14, 2019

Codecov Report

Merging #2037 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2037      +/-   ##
============================================
- Coverage      55.01%     55%   -0.02%     
+ Complexity      2474    2472       -2     
============================================
  Files            444     444              
  Lines          14793   14794       +1     
  Branches        1746    1746              
============================================
- Hits            8138    8137       -1     
+ Misses          5909    5908       -1     
- Partials         746     749       +3
Impacted Files Coverage Δ Complexity Δ
...tasource/sql/struct/cache/MysqlTableMetaCache.java 81.08% <100%> (+0.17%) 11 <0> (ø) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 84.54% <0%> (-0.49%) 67% <0%> (-1%)
...o/seata/server/coordinator/DefaultCoordinator.java 48.01% <0%> (-0.4%) 27% <0%> (-1%)
...server/store/file/FileTransactionStoreManager.java 56.19% <0%> (-0.32%) 29% <0%> (ø)
...very/registry/zk/ZookeeperRegisterServiceImpl.java 63.7% <0%> (+0.8%) 24% <0%> (ø) ⬇️

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit f078e42 into apache:develop Dec 14, 2019
funky-eyes added a commit to funky-eyes/seata that referenced this pull request Dec 14, 2019
bugfix: fix mysql connection unable to release (apache#2037)
@slievrly
Copy link
Member

@a364176773 great found. Does Oracle have the same problem?

@funky-eyes
Copy link
Contributor Author

@a364176773 great found. Does Oracle have the same problem?

Not yet discovered

@wangliang181230 wangliang181230 added this to the 1.0.0 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants