Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: startup failure when dynamic proxy is turned on and use druid-spring-boot-starter #2043

Merged
merged 8 commits into from
Dec 17, 2019

Conversation

kclizhiwei
Copy link
Contributor

@kclizhiwei kclizhiwei commented Dec 16, 2019

…druid-spring-boot-starter dependency is used

Ⅰ. Describe what this PR did

Fix startup failure issue caused when dynamic proxy is turned on and druid-spring-boot-starter dependency is used

Ⅱ. Does this pull request fix one issue?

fixes #2045

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

…druid-spring-boot-starter dependency is used
@codecov-io
Copy link

codecov-io commented Dec 16, 2019

Codecov Report

Merging #2043 into develop will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2043      +/-   ##
=============================================
- Coverage      55.58%   55.56%   -0.03%     
- Complexity      2522     2523       +1     
=============================================
  Files            445      445              
  Lines          14838    14848      +10     
  Branches        1749     1751       +2     
=============================================
+ Hits            8248     8250       +2     
- Misses          5826     5835       +9     
+ Partials         764      763       -1
Impacted Files Coverage Δ Complexity Δ
...ta/spring/annotation/GlobalTransactionScanner.java 48.24% <0%> (-0.43%) 17 <0> (ø)
...in/java/io/seata/spring/util/SpringProxyUtils.java 3.22% <0%> (-0.55%) 3 <0> (ø)
...server/store/file/FileTransactionStoreManager.java 57.14% <0%> (+0.63%) 30% <0%> (+1%) ⬆️

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to put this method in the SpringProxyUtils.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slievrly
Copy link
Member

@lizwmaster add issue to describe to what happened and the reason why happened.

@slievrly slievrly changed the title Fix startup failure issue caused when dynamic proxy is turned on and … bugfix: startup failure when dynamic proxy is turned on and use druid-spring-boot-starter Dec 16, 2019
@zjinlei zjinlei added this to the 1.0 milestone Dec 17, 2019
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit 3ee4885 into apache:develop Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

startup failure when dynamic proxy is turned on and use druid-spring-boot-starter
5 participants