-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: startup failure when dynamic proxy is turned on and use druid-spring-boot-starter #2043
Conversation
…druid-spring-boot-starter dependency is used
Codecov Report
@@ Coverage Diff @@
## develop #2043 +/- ##
=============================================
- Coverage 55.58% 55.56% -0.03%
- Complexity 2522 2523 +1
=============================================
Files 445 445
Lines 14838 14848 +10
Branches 1749 1751 +2
=============================================
+ Hits 8248 8250 +2
- Misses 5826 5835 +9
+ Partials 764 763 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to put this method in the SpringProxyUtils.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@lizwmaster add issue to describe to what happened and the reason why happened. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…druid-spring-boot-starter dependency is used
Ⅰ. Describe what this PR did
Fix startup failure issue caused when dynamic proxy is turned on and druid-spring-boot-starter dependency is used
Ⅱ. Does this pull request fix one issue?
fixes #2045
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews