-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: optimize ColumnUtils.addEscape method performance #2044
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2044 +/- ##
=============================================
+ Coverage 51.06% 51.46% +0.40%
+ Complexity 2764 2662 -102
=============================================
Files 550 529 -21
Lines 17525 16959 -566
Branches 2064 2051 -13
=============================================
- Hits 8949 8728 -221
+ Misses 7735 7406 -329
+ Partials 841 825 -16 |
rm-datasource/src/main/java/io/seata/rm/datasource/ColumnUtils.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/ColumnUtils.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please resolve conflicting file. |
Please solve the conflict. |
Codecov Report
@@ Coverage Diff @@
## develop #2044 +/- ##
=============================================
+ Coverage 50.98% 51.15% +0.16%
- Complexity 2847 2848 +1
=============================================
Files 566 566
Lines 18053 18075 +22
Branches 2102 2141 +39
=============================================
+ Hits 9205 9246 +41
- Misses 7938 7942 +4
+ Partials 910 887 -23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
optimize ColumnUtils.addEscape method performance
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews