Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize ColumnUtils.addEscape method performance #2044

Merged
merged 14 commits into from
May 25, 2020

Conversation

yangfuhai
Copy link
Contributor

Ⅰ. Describe what this PR did

optimize ColumnUtils.addEscape method performance

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Dec 16, 2019

Codecov Report

Merging #2044 into develop will increase coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2044      +/-   ##
=============================================
+ Coverage      51.06%   51.46%   +0.40%     
+ Complexity      2764     2662     -102     
=============================================
  Files            550      529      -21     
  Lines          17525    16959     -566     
  Branches        2064     2051      -13     
=============================================
- Hits            8949     8728     -221     
+ Misses          7735     7406     -329     
+ Partials         841      825      -16     
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/seata/rm/datasource/ColumnUtils.java 76.78% <100.00%> (+1.31%) 18.00 <0.00> (ø)
...integration/http/HttpHandlerExceptionResolver.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...ration/http/TransactionPropagationIntercepter.java 0.00% <0.00%> (-46.16%) 0.00% <0.00%> (-3.00%)
...in/java/io/seata/integration/http/XidResource.java 0.00% <0.00%> (-30.77%) 0.00% <0.00%> (-2.00%)
...o/seata/integration/http/AbstractHttpExecutor.java 53.70% <0.00%> (-9.26%) 10.00% <0.00%> (ø%)
...io/seata/integration/http/DefaultHttpExecutor.java 57.14% <0.00%> (-8.58%) 8.00% <0.00%> (-2.00%)
...va/io/seata/core/rpc/netty/RpcClientBootstrap.java 33.70% <0.00%> (-8.55%) 6.00% <0.00%> (ø%)
...zer/seata/protocol/AbstractResultMessageCodec.java 67.74% <0.00%> (-7.26%) 5.00% <0.00%> (ø%)
...in/java/io/seata/rm/datasource/util/JdbcUtils.java 4.76% <0.00%> (-4.63%) 7.00% <0.00%> (-1.00%)
...o/seata/server/coordinator/DefaultCoordinator.java 54.08% <0.00%> (-0.92%) 28.00% <0.00%> (-1.00%)
... and 37 more

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi
Copy link
Member

Please resolve conflicting file.

@l81893521
Copy link
Contributor

Please solve the conflict.

@l81893521 l81893521 added status: waiting-for-feedback Waiting for feedback status: merge-conflict Category prs with merge conflict. labels Apr 1, 2020
@zjinlei zjinlei removed status: merge-conflict Category prs with merge conflict. status: waiting-for-feedback Waiting for feedback labels Apr 6, 2020
@zjinlei zjinlei added this to the 1.2.0 milestone Apr 10, 2020
@slievrly slievrly modified the milestones: 1.2.0, 1.3.0 Apr 12, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2020

Codecov Report

Merging #2044 into develop will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2044      +/-   ##
=============================================
+ Coverage      50.98%   51.15%   +0.16%     
- Complexity      2847     2848       +1     
=============================================
  Files            566      566              
  Lines          18053    18075      +22     
  Branches        2102     2141      +39     
=============================================
+ Hits            9205     9246      +41     
- Misses          7938     7942       +4     
+ Partials         910      887      -23     
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/seata/rm/datasource/ColumnUtils.java 76.78% <100.00%> (+1.31%) 18.00 <0.00> (ø)
...in/java/io/seata/server/session/GlobalSession.java 83.71% <0.00%> (-0.55%) 71.00% <0.00%> (ø%)
...java/io/seata/spring/tcc/TccActionInterceptor.java 11.36% <0.00%> (-0.27%) 2.00% <0.00%> (ø%)
...n/java/io/seata/rm/datasource/ConnectionProxy.java 28.00% <0.00%> (-0.23%) 13.00% <0.00%> (ø%)
...a/io/seata/core/rpc/netty/AbstractRpcRemoting.java 9.28% <0.00%> (-0.16%) 5.00% <0.00%> (ø%)
...in/java/io/seata/server/session/BranchSession.java 78.10% <0.00%> (+0.07%) 44.00% <0.00%> (ø%)
...a/server/storage/db/store/LogStoreDataBaseDAO.java 71.76% <0.00%> (+0.09%) 34.00% <0.00%> (ø%)
...in/java/io/seata/tm/api/TransactionalTemplate.java 64.34% <0.00%> (+0.31%) 25.00% <0.00%> (ø%)
...ain/java/io/seata/config/ConfigurationFactory.java 50.00% <0.00%> (+0.98%) 4.00% <0.00%> (ø%)
...erver/storage/file/session/FileSessionManager.java 64.16% <0.00%> (+2.49%) 28.00% <0.00%> (+1.00%)
... and 21 more

@l81893521 l81893521 added the module/rm-datasource rm-datasource module label May 23, 2020
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 changed the title optimize ColumnUtils.addEscape method performance optimize: optimize ColumnUtils.addEscape method performance May 25, 2020
@l81893521 l81893521 merged commit 7e04d2a into apache:develop May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants