Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: if add configListener but dataId not exist, it will throw NPE #2050

Merged
merged 3 commits into from
Dec 18, 2019
Merged

bugfix: if add configListener but dataId not exist, it will throw NPE #2050

merged 3 commits into from
Dec 18, 2019

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: if add configListener but dataId not exist, it will throw NPE

Ⅱ. Does this pull request fix one issue?

fix #2049

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Dec 17, 2019

Codecov Report

Merging #2050 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2050   +/-   ##
==========================================
  Coverage      55.55%   55.55%           
+ Complexity      2524     2522    -2     
==========================================
  Files            445      445           
  Lines          14848    14848           
  Branches        1751     1751           
==========================================
  Hits            8249     8249           
+ Misses          5837     5835    -2     
- Partials         762      764    +2
Impacted Files Coverage Δ Complexity Δ
...c/main/java/io/seata/config/FileConfiguration.java 36.79% <100%> (ø) 6 <0> (ø) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 84.54% <0%> (-0.49%) 67% <0%> (-1%)
...o/seata/server/coordinator/DefaultCoordinator.java 48.01% <0%> (-0.4%) 27% <0%> (-1%)
...server/store/file/FileTransactionStoreManager.java 57.14% <0%> (+0.63%) 29% <0%> (ø) ⬇️

Signed-off-by: slievrly <slievrly@163.com>
@slievrly slievrly added this to the 1.0 milestone Dec 17, 2019
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lovepoem lovepoem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lovepoem lovepoem merged commit a60ee58 into apache:develop Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if add configListener but dataId not exist, it will throw NPE.
5 participants