Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: when tableName is keyword, the insert operation will get afterImage fail #2053

Merged
merged 9 commits into from
Dec 18, 2019
Merged

bugfix: when tableName is keyword, the insert operation will get afterImage fail #2053

merged 9 commits into from
Dec 18, 2019

Conversation

slievrly
Copy link
Member

Ⅰ. Describe what this PR did

bugfix: when tableName is keyword, the insert operation will get afterImage fail

Ⅱ. Does this pull request fix one issue?

fix #2052

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
…rImage fail.

Signed-off-by: slievrly <slievrly@163.com>
…rImage fail.

Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Dec 17, 2019

Codecov Report

Merging #2053 into develop will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2053      +/-   ##
=============================================
+ Coverage      55.34%   55.37%   +0.02%     
- Complexity      2522     2525       +3     
=============================================
  Files            445      445              
  Lines          14900    14901       +1     
  Branches        1765     1765              
=============================================
+ Hits            8247     8251       +4     
  Misses          5889     5889              
+ Partials         764      761       -3
Impacted Files Coverage Δ Complexity Δ
.../java/io/seata/config/ConfigurationChangeType.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...java/io/seata/config/ConfigurationChangeEvent.java 38.46% <ø> (ø) 6 <0> (ø) ⬇️
...a/io/seata/config/ConfigurationChangeListener.java 41.66% <ø> (ø) 4 <0> (ø) ⬇️
.../rm/datasource/exec/BaseTransactionalExecutor.java 44.35% <0%> (-0.37%) 20 <0> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 48.41% <0%> (+0.39%) 28% <0%> (+1%) ⬆️
...in/java/io/seata/server/session/GlobalSession.java 85.02% <0%> (+0.48%) 68% <0%> (+1%) ⬆️
...server/store/file/FileTransactionStoreManager.java 57.14% <0%> (+0.63%) 30% <0%> (+1%) ⬆️

…rImage fail.

Signed-off-by: slievrly <slievrly@163.com>
…rImage fail.

Signed-off-by: slievrly <slievrly@163.com>
@slievrly slievrly added this to the 1.0 milestone Dec 17, 2019
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lovepoem lovepoem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lovepoem lovepoem merged commit 4196b31 into apache:develop Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if tableName is keyword, get data image error
4 participants