Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: RetryRollbackingSessionManager lost Rollbacking #2054

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

zjinlei
Copy link
Contributor

@zjinlei zjinlei commented Dec 18, 2019

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

image

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Dec 18, 2019

Codecov Report

Merging #2054 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2054      +/-   ##
=============================================
- Coverage      55.57%   55.54%   -0.03%     
+ Complexity      2524     2522       -2     
=============================================
  Files            445      445              
  Lines          14848    14848              
  Branches        1751     1751              
=============================================
- Hits            8252     8248       -4     
- Misses          5835     5836       +1     
- Partials         761      764       +3
Impacted Files Coverage Δ Complexity Δ
...eata/server/session/db/DataBaseSessionManager.java 33.87% <ø> (ø) 12 <0> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 56.5% <0%> (-0.96%) 29% <0%> (ø)
...in/java/io/seata/server/session/GlobalSession.java 84.54% <0%> (-0.49%) 67% <0%> (-1%)
...o/seata/server/coordinator/DefaultCoordinator.java 48.01% <0%> (-0.4%) 27% <0%> (-1%)
...very/registry/zk/ZookeeperRegisterServiceImpl.java 63.7% <0%> (+0.8%) 24% <0%> (ø) ⬇️

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei added this to the 1.0 milestone Dec 18, 2019
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 4da224c into apache:develop Dec 18, 2019
@zjinlei zjinlei deleted the bugfix/rollbacking branch December 19, 2019 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants