refactor: Replace tableMetaCache and undoLogManager with SPI #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2055 +/- ##
============================================
- Coverage 54.52% 54.32% -0.2%
- Complexity 2471 2492 +21
============================================
Files 446 454 +8
Lines 14717 14880 +163
Branches 1729 1753 +24
============================================
+ Hits 8024 8084 +60
- Misses 5937 6025 +88
- Partials 756 771 +15
|
|
Thanks! |
|
I hope you can join the seata development team, i8vx5rv is my DingTalk ID, please add friends. |
|
thanks, My pleasure |
# Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/AbstractConnectionProxy.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/cache/MysqlTableMetaCache.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/cache/OracleTableMetaCache.java # rm-datasource/src/main/java/io/seata/rm/datasource/undo/AbstractUndoLogManager.java
zjinlei
reviewed
Dec 24, 2019
zjinlei
changed the title
zjinlei
changed the title
# Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/TableMetaCacheFactory.java # rm-datasource/src/main/java/io/seata/rm/datasource/undo/UndoExecutorFactory.java # rm-datasource/src/main/java/io/seata/rm/datasource/undo/UndoLogManagerFactory.java # rm-datasource/src/main/java/io/seata/rm/datasource/undo/oracle/OracleUndoLogManager.java # sqlparser/seata-sqlparser-druid/src/main/java/io/seata/sqlparser/druid/MySqlOperateRecognizerHolder.java # sqlparser/seata-sqlparser-druid/src/main/java/io/seata/sqlparser/druid/oracle/OracleOperateRecognizerHolder.java
# Conflicts: # sqlparser/seata-sqlparser-druid/src/main/java/io/seata/sqlparser/druid/mysql/MySQLOperateRecognizerHolder.java
slievrly
reviewed
Jan 19, 2020
| @@ -288,7 +281,7 @@ public void undo(DataSourceProxy dataSourceProxy, String xid, long branchId) thr | |||
| Collections.reverse(sqlUndoLogs); | |||
| } | |||
| for (SQLUndoLog sqlUndoLog : sqlUndoLogs) { | |||
| TableMeta tableMeta = TableMetaCacheFactory.getTableMetaCache(dataSourceProxy).getTableMeta( | |||
| TableMeta tableMeta = TableMetaCacheFactory.getTableMetaCache(dataSourceProxy.getDbType()).getTableMeta( | |||
There was a problem hiding this comment.
dataSourceProxy.getDbType() return SqlParser.getDbType, but in other places is returned we define constants, whether there is the risk of inconsistent?
There was a problem hiding this comment.
Yes, there is a problem. It has been corrected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Replace with SPI
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews