Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean: remove non-javadoc element #2056

Merged
merged 6 commits into from
Dec 19, 2019
Merged

clean: remove non-javadoc element #2056

merged 6 commits into from
Dec 19, 2019

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Dec 18, 2019

Ⅰ. Describe what this PR did

clean: remove non-javadoc element

Ⅱ. Does this pull request fix one issue?

fix #1676

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Dec 18, 2019

Codecov Report

Merging #2056 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2056      +/-   ##
=============================================
- Coverage      55.25%   55.24%   -0.01%     
- Complexity      2522     2523       +1     
=============================================
  Files            446      446              
  Lines          14927    14927              
  Branches        1770     1770              
=============================================
- Hits            8248     8247       -1     
- Misses          5911     5912       +1     
  Partials         768      768
Impacted Files Coverage Δ Complexity Δ
...c/main/java/io/seata/core/rpc/netty/RpcServer.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...seata/core/rpc/netty/ChannelAuthHealthChecker.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../io/seata/common/exception/FrameworkException.java 85.18% <ø> (ø) 13 <0> (ø) ⬇️
...scovery/registry/zk/ZookeeperRegistryProvider.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...ava/io/seata/core/constants/ConfigurationKeys.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...discovery/registry/etcd3/EtcdRegistryProvider.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...ava/io/seata/core/rpc/netty/RmMessageListener.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...e/protocol/transaction/BranchRollbackResponse.java 50% <ø> (ø) 1 <0> (ø) ⬇️
...ta/discovery/registry/FileRegistryServiceImpl.java 0% <ø> (ø) 0 <0> (ø) ⬇️
core/src/main/java/io/seata/core/store/LockDO.java 95.83% <ø> (ø) 15 <0> (ø) ⬇️
... and 144 more

Copy link
Member

@lovepoem lovepoem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added this to the 1.0 milestone Dec 19, 2019
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 73e9809 into apache:develop Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@date is error javadoc element
4 participants