bugfix: fix repeated rollback caused by asynchronous rollback thread #2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2059 +/- ##
=============================================
- Coverage 55.32% 55.31% -0.02%
+ Complexity 2524 2523 -1
=============================================
Files 446 446
Lines 14910 14913 +3
Branches 1765 1766 +1
=============================================
Hits 8249 8249
- Misses 5899 5900 +1
- Partials 762 764 +2
|
slievrly
reviewed
Dec 18, 2019
| @@ -381,6 +381,10 @@ protected void handleRetryRollbacking() { | |||
| long now = System.currentTimeMillis(); | |||
| for (GlobalSession rollbackingSession : rollbackingSessions) { | |||
| try { | |||
| //prevent repeated rollback | |||
| if (rollbackingSession.getStatus().equals(GlobalStatus.Rollbacking) && !rollbackingSession.isTimeout()) { | |||
There was a problem hiding this comment.
if throw RunTimeException it will no longer rollback.
There was a problem hiding this comment.
I think it will keep rollback
zjinlei
reviewed
Dec 19, 2019
| * @return if true force roll back | ||
| */ | ||
| public boolean isRollbackingDead() { | ||
| return (System.currentTimeMillis() - beginTime) > (3 * 6000); |
There was a problem hiding this comment.
(System.currentTimeMillis() - beginTime) > (3 * 6000 + timeout);
Suggested overload isTimeout()
There was a problem hiding this comment.
My mistake, you are right!
slievrly
approved these changes
Dec 19, 2019
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
schedule retry rollback thread pool cause repeated rollback
Ⅱ. Does this pull request fix one issue?
#2058
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews