Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: thread unsafe which missing double check when initial eureka client #2066

Merged
merged 2 commits into from
Dec 20, 2019
Merged

bugfix: thread unsafe which missing double check when initial eureka client #2066

merged 2 commits into from
Dec 20, 2019

Conversation

helloworlde
Copy link
Contributor

Ⅰ. Describe what this PR did

fixed issue #2063 which missing double check when initial eureka client.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@zjinlei zjinlei changed the title bugfix: fixed issue #2063 which missing double check when initial eureka client bugfix: thread unsafe which missing double check when initial eureka client Dec 20, 2019
@codecov-io
Copy link

codecov-io commented Dec 20, 2019

Codecov Report

Merging #2066 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2066      +/-   ##
=============================================
- Coverage      55.26%   55.26%   -0.01%     
+ Complexity      2524     2523       -1     
=============================================
  Files            446      446              
  Lines          14927    14927              
  Branches        1770     1770              
=============================================
- Hits            8250     8249       -1     
- Misses          5910     5911       +1     
  Partials         767      767
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 56.5% <0%> (-0.32%) 29% <0%> (-1%)

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 1d562a6 into apache:develop Dec 20, 2019
@wangliang181230 wangliang181230 added this to the 1.0.0 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants