Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add apollo configuration namespace. #2086

Merged
merged 13 commits into from
Jan 23, 2020

Conversation

objcoding
Copy link
Contributor

@objcoding objcoding commented Dec 24, 2019

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #1555

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Dec 24, 2019

Codecov Report

Merging #2086 into develop will decrease coverage by 0.02%.
The diff coverage is 11.11%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2086      +/-   ##
=============================================
- Coverage      53.13%   53.11%   -0.03%     
  Complexity      2513     2513              
=============================================
  Files            485      485              
  Lines          15364    15355       -9     
  Branches        1771     1771              
=============================================
- Hits            8164     8156       -8     
  Misses          6413     6413              
+ Partials         787      786       -1
Impacted Files Coverage Δ Complexity Δ
...eata/server/session/db/DataBaseSessionManager.java 35% <ø> (+1.12%) 12 <0> (ø) ⬇️
...ta/spring/boot/autoconfigure/StarterConstants.java 97.36% <ø> (-0.41%) 1 <0> (ø)
...gure/provider/SpringBootConfigurationProvider.java 33.33% <0%> (ø) 9 <0> (ø) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 49.8% <50%> (ø) 30 <0> (ø) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 62.29% <0%> (-0.82%) 24% <0%> (ø)

@zjinlei zjinlei added this to the 1.1.0 milestone Jan 2, 2020
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ConfigApolloProperties missing the namespace field?

@objcoding
Copy link
Contributor Author

Is ConfigApolloProperties missing the namespace field?

resolved.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@helloworlde helloworlde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei closed this Jan 22, 2020
@zjinlei zjinlei reopened this Jan 22, 2020
@slievrly slievrly merged commit 391c961 into apache:develop Jan 23, 2020
booogu pushed a commit to booogu/seata that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seata config with apoll is not easy to uses enough, can you optimize it?
7 participants