optimize:refactor of auto proxying of datasource. #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2095 +/- ##
==========================================
Coverage ? 54.41%
Complexity ? 2472
==========================================
Files ? 447
Lines ? 14750
Branches ? 1734
==========================================
Hits ? 8026
Misses ? 5967
Partials ? 757 |
zjinlei
reviewed
Jan 1, 2020
spring/src/main/java/io/seata/spring/annotation/datasource/EnableAutoDataSourceProxy.java
Outdated
Show resolved
Hide resolved
...ng/src/main/java/io/seata/spring/annotation/datasource/SeataDataSourceBeanPostProcessor.java
Outdated
Show resolved
Hide resolved
...ng/src/main/java/io/seata/spring/annotation/datasource/SeataDataSourceBeanPostProcessor.java
Outdated
Show resolved
Hide resolved
…tor_ds_auto_proxy
slievrly
reviewed
Jan 12, 2020
slievrly
reviewed
Jan 13, 2020
spring/src/main/java/io/seata/spring/annotation/datasource/AutoDataSourceProxyRegistrar.java
Show resolved
Hide resolved
slievrly
reviewed
Jan 14, 2020
There was a problem hiding this comment.
- check spring-cloud-alibaba-seata sample with dependency seata-spring-boot-starter result is ok(adapter: use seata-spring-boot-starter's autoConfiguration instead of spring-cloud-alibaba-seata-starter's autoConfiguration alibaba/spring-cloud-alibaba#1154).
slievrly
approved these changes
Jan 14, 2020
XCXCXCXCX
reviewed
Jan 14, 2020
...ng/src/main/java/io/seata/spring/annotation/datasource/SeataDataSourceBeanPostProcessor.java
Show resolved
Hide resolved
...ng/src/main/java/io/seata/spring/annotation/datasource/SeataDataSourceBeanPostProcessor.java
Show resolved
Hide resolved
spring/src/main/java/io/seata/spring/annotation/datasource/EnableAutoDataSourceProxy.java
Show resolved
Hide resolved
zjinlei
reviewed
Jan 14, 2020
...oot-starter/src/main/java/io/seata/spring/boot/autoconfigure/properties/SeataProperties.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
This PR is totally the refactor of auto proxying of datasource.
Add a new annotation @EnableAutoDataSourceProxy.
User can choose to use CGLIB proxy or JDK proxy.
fix known problems,like
1.final class can't be proxied.
2.com.sun.proxy.$Proxy153 cannot be cast to com.zaxxer.hikari.HikariDataSource
etc.
Ⅱ. Does this pull request fix one issue?
fixex #2083 #2124
Ⅲ. Why don't you add test cases (unit test/integration test)?
I've done integration testing.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews