Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: tm module code style #2099

Merged
merged 2 commits into from
Dec 31, 2019
Merged

Conversation

EZKAYOTWJPRKXWCUYEEB
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Dec 27, 2019

Codecov Report

Merging #2099 into develop will decrease coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2099      +/-   ##
=============================================
- Coverage      55.16%   55.15%   -0.01%     
+ Complexity      2515     2513       -2     
=============================================
  Files            446      446              
  Lines          14922    14915       -7     
  Branches        1768     1765       -3     
=============================================
- Hits            8232     8227       -5     
  Misses          5922     5922              
+ Partials         768      766       -2
Impacted Files Coverage Δ Complexity Δ
...ata/tm/api/transaction/TransactionHookManager.java 85.71% <ø> (+5.71%) 6 <0> (ø) ⬇️
...java/io/seata/tm/api/GlobalTransactionContext.java 100% <100%> (ø) 6 <2> (ø) ⬇️
...a/io/seata/tm/api/transaction/TransactionInfo.java 95.23% <100%> (ø) 12 <0> (-1) ⬇️
...ain/java/io/seata/tm/TransactionManagerHolder.java 84.61% <100%> (ø) 4 <0> (ø) ⬇️
...java/io/seata/tm/api/DefaultGlobalTransaction.java 73.33% <50%> (+2.36%) 19 <0> (ø) ⬇️
...ava/io/seata/tm/api/DefaultFailureHandlerImpl.java 75% <50%> (+2.27%) 6 <0> (ø) ⬇️
...java/io/seata/tm/api/transaction/RollbackRule.java 92.85% <0%> (-7.15%) 14% <0%> (-1%)
...very/registry/zk/ZookeeperRegisterServiceImpl.java 62.9% <0%> (-0.81%) 24% <0%> (ø)

Copy link
Contributor

@lightClouds917 lightClouds917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EZKAYOTWJPRKXWCUYEEB EZKAYOTWJPRKXWCUYEEB changed the title optimize: rm module optimize: tm module Dec 27, 2019
Copy link
Contributor

@lightClouds917 lightClouds917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 changed the title optimize: tm module optimize: tm module code style Dec 30, 2019
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 13c7594 into apache:develop Dec 31, 2019
@slievrly slievrly added this to the 1.1.0 milestone Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants