-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature : support zip bzip2 7z compressor #2108
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2108 +/- ##
==========================================
Coverage 51.62% 51.62%
Complexity 2692 2692
==========================================
Files 517 517
Lines 16728 16728
Branches 2038 2038
==========================================
Hits 8635 8635
Misses 7283 7283
Partials 810 810 |
compressor/seata-compressor-zip/src/main/java/io/seata/compressor/zip/ZipUtil.java
Outdated
Show resolved
Hide resolved
compressor/seata-compressor-zip/src/main/java/io/seata/compressor/zip/ZipUtil.java
Outdated
Show resolved
Hide resolved
compressor/seata-compressor-bzip2/src/main/java/io/seata/compressor/bzip2/BZip2Util.java
Outdated
Show resolved
Hide resolved
compressor/seata-compressor-bzip2/src/main/java/io/seata/compressor/bzip2/BZip2Util.java
Outdated
Show resolved
Hide resolved
compressor/seata-compressor-7z/src/main/java/io/seata/compressor/sevenz/SevenZUtil.java
Outdated
Show resolved
Hide resolved
compressor/seata-compressor-7z/src/main/java/io/seata/compressor/sevenz/SevenZUtil.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.I left some comments.
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
test BZIP2 ZIP SEVENZ both failed |
Unit test can pass. How to generate this? I don't quite understand |
need to configure them in seata-all pom.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews