Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature : support zip bzip2 7z compressor #2108

Merged
merged 36 commits into from
Mar 1, 2020

Conversation

ph3636
Copy link
Contributor

@ph3636 ph3636 commented Dec 30, 2019

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Dec 30, 2019

Codecov Report

Merging #2108 into develop will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2108   +/-   ##
==========================================
  Coverage      51.62%   51.62%           
  Complexity      2692     2692           
==========================================
  Files            517      517           
  Lines          16728    16728           
  Branches        2038     2038           
==========================================
  Hits            8635     8635           
  Misses          7283     7283           
  Partials         810      810           

@zjinlei zjinlei added this to the 1.1.0 milestone Jan 2, 2020
@xingfudeshi xingfudeshi self-requested a review January 7, 2020 14:33
@xingfudeshi xingfudeshi reopened this Jan 25, 2020
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.I left some comments.

@zjinlei zjinlei added this to the 1.2.0 milestone Feb 5, 2020
@ph3636
Copy link
Contributor Author

ph3636 commented Feb 10, 2020

Thanks.I left some comments.

done

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

zjinlei
zjinlei previously approved these changes Feb 28, 2020
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei dismissed their stale review February 29, 2020 03:42

test failed

@zjinlei
Copy link
Contributor

zjinlei commented Feb 29, 2020

test BZIP2 ZIP SEVENZ both failed
io.netty.handler.codec.CorruptedFrameException: Adjusted frame length (0) is less than lengthFieldEndOffset: 7

@ph3636
Copy link
Contributor Author

ph3636 commented Mar 1, 2020

test BZIP2 ZIP SEVENZ both failed
io.netty.handler.codec.CorruptedFrameException: Adjusted frame length (0) is less than lengthFieldEndOffset: 7

Unit test can pass. How to generate this? I don't quite understand

@zjinlei
Copy link
Contributor

zjinlei commented Mar 1, 2020

test BZIP2 ZIP SEVENZ both failed
io.netty.handler.codec.CorruptedFrameException: Adjusted frame length (0) is less than lengthFieldEndOffset: 7

Unit test can pass. How to generate this? I don't quite understand

need to configure them in seata-all pom.xml

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 8339344 into apache:develop Mar 1, 2020
@ph3636 ph3636 deleted the zip_compressor branch March 9, 2020 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants