Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: saga concurrent asynchronous execution with duplicate primary key xid. #2167

Merged
merged 9 commits into from
Jan 17, 2020
Merged

bugfix: saga concurrent asynchronous execution with duplicate primary key xid. #2167

merged 9 commits into from
Jan 17, 2020

Conversation

long187
Copy link
Contributor

@long187 long187 commented Jan 10, 2020

Ⅰ. Describe what this PR did

bugfix: saga concurrent asynchronous execution with duplicate primary key xid.

Ⅱ. Does this pull request fix one issue?

#2165

@codecov-io
Copy link

codecov-io commented Jan 13, 2020 •
edited

Codecov Report

Merging #2167 into develop will decrease coverage by 0.03%.
The diff coverage is 50%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2167      +/-   ##
=============================================
- Coverage       54.4%   54.37%   -0.04%     
  Complexity      2469     2469              
=============================================
  Files            447      447              
  Lines          14750    14749       -1     
  Branches        1734     1734              
=============================================
- Hits            8025     8020       -5     
- Misses          5966     5968       +2     
- Partials         759      761       +2
Impacted Files Coverage Δ Complexity Δ
...src/main/java/io/seata/server/ParameterParser.java 44.68% <0%> (-2.13%) 11 <1> (ø)
...ain/java/io/seata/config/ConfigurationFactory.java 51.02% <100%> (-0.98%) 3 <0> (ø)
...server/store/file/FileTransactionStoreManager.java 56.5% <0%> (-0.96%) 29% <0%> (ø)

zjinlei
zjinlei approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei added this to the 1.1.0 milestone Jan 15, 2020
l81893521
l81893521 approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangthen zhangthen merged commit 02ad392 into apache:develop Jan 17, 2020
booogu pushed a commit to booogu/seata that referenced this pull request Feb 12, 2020
@long187 @booogu
bugfix: saga concurrent asynchronous execution with duplicate primary…
eb5bf6c 
… key xid. (apache#2167)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l81893521 l81893521 l81893521 approved these changes

@zjinlei zjinlei zjinlei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@long187 @codecov-io @l81893521 @zjinlei @zhangthen @xingfudeshi