-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: optimize script and add script usage demo. #2171
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2171 +/- ##
=============================================
- Coverage 53.16% 53.05% -0.11%
+ Complexity 2513 2499 -14
=============================================
Files 485 485
Lines 15348 15302 -46
Branches 1770 1754 -16
=============================================
- Hits 8159 8118 -41
- Misses 6404 6407 +3
+ Partials 785 777 -8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nacos SGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
以上脚本实战可以成功!前提:config.txt 与nacos-config.sh 在同一目录;
本人修改了原脚本 for line in
这里修改为:
shellPath=cd $(dirname $0);pwd -P
for line in $(cat $shellPath/config.txt); do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nacos脚本实战可以成功!前提:config.txt 与nacos-config.sh 在同一目录;
本人修改了原脚本 for line in
这里修改为:
shellPath=cd $(dirname $0);pwd -P
for line in $(cat $shellPath/config.txt); do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Redis registry just added three items: |
Please add the following new config items. |
Pull |
script synchronization for redis is not covered here. |
Ⅰ. Describe what this PR did
1.optimize script parameter input;
2.add script usage demo;
3.fix create temp log error;
4.remove parameter warning.
5.add group and namespace in nacos script