Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize script and add script usage demo. #2171

Merged
merged 17 commits into from
Feb 3, 2020

Conversation

objcoding
Copy link
Contributor

@objcoding objcoding commented Jan 11, 2020

Ⅰ. Describe what this PR did

1.optimize script parameter input;
2.add script usage demo;
3.fix create temp log error;
4.remove parameter warning.
5.add group and namespace in nacos script

@codecov-io
Copy link

codecov-io commented Jan 11, 2020

Codecov Report

Merging #2171 into develop will decrease coverage by 0.1%.
The diff coverage is 87.09%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2171      +/-   ##
=============================================
- Coverage      53.16%   53.05%   -0.11%     
+ Complexity      2513     2499      -14     
=============================================
  Files            485      485              
  Lines          15348    15302      -46     
  Branches        1770     1754      -16     
=============================================
- Hits            8159     8118      -41     
- Misses          6404     6407       +3     
+ Partials         785      777       -8
Impacted Files Coverage Δ Complexity Δ
...tasource/undo/oracle/OracleUndoExecutorHolder.java 0% <ø> (-40%) 0 <0> (-2)
...datasource/undo/mysql/MySQLUndoExecutorHolder.java 100% <ø> (ø) 4 <0> (-1) ⬇️
...rser/druid/mysql/MySQLOperateRecognizerHolder.java 28.57% <ø> (-8.93%) 2 <0> (-1)
...ata/rm/datasource/undo/AbstractUndoLogManager.java 59.37% <ø> (ø) 17 <0> (ø) ⬇️
...asource/sql/struct/cache/OracleTableMetaCache.java 77.77% <ø> (-0.28%) 10 <0> (-1)
.../rm/datasource/undo/mysql/MySQLUndoLogManager.java 81.81% <ø> (-0.54%) 6 <0> (-1)
...urce/undo/oracle/keyword/OracleKeywordChecker.java 100% <ø> (ø) 7 <0> (-1) ⬇️
...er/druid/oracle/OracleOperateRecognizerHolder.java 0% <ø> (-25%) 0 <0> (-2)
...source/undo/mysql/keyword/MySQLKeywordChecker.java 98.91% <ø> (-0.01%) 5 <0> (-1)
...tasource/sql/struct/cache/MysqlTableMetaCache.java 82.55% <ø> (-0.21%) 10 <0> (-1)
... and 8 more

@objcoding objcoding changed the title optimize: optimize script parameter input and add script usage demo. optimize: optimize script and add script usage demo. Jan 11, 2020
@zjinlei zjinlei added this to the 1.1.0 milestone Jan 12, 2020
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nacos SGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@usench usench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

以上脚本实战可以成功!前提:config.txt 与nacos-config.sh 在同一目录;
本人修改了原脚本 for line in $(cat $(dirname "$PWD")/config.txt); do ,
这里修改为:
shellPath=cd $(dirname $0);pwd -P
for line in $(cat $shellPath/config.txt); do

Copy link

@usench usench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nacos脚本实战可以成功!前提:config.txt 与nacos-config.sh 在同一目录;
本人修改了原脚本 for line in $(cat $(dirname "$PWD")/config.txt); do ,
这里修改为:
shellPath=cd $(dirname $0);pwd -P
for line in $(cat $shellPath/config.txt); do

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi
Copy link
Member

Redis registry just added three items:
password = ""
cluster = "default"
timeout = "0"

@xingfudeshi
Copy link
Member

Please add the following new config items.
password = ""
cluster = "default"
timeout = "0"

@dstiers-1109
Copy link

Pull

@xingfudeshi
Copy link
Member

@objcoding

@slievrly
Copy link
Member

slievrly commented Feb 3, 2020

Please add the following new config items.
password = ""
cluster = "default"
timeout = "0"

script synchronization for redis is not covered here.

@slievrly slievrly merged commit 053646b into apache:develop Feb 3, 2020
booogu pushed a commit to booogu/seata that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants