Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix configuration center can't read configuration using SpringCloudConfig #2172

Merged
merged 31 commits into from
Feb 5, 2020
Merged

Conversation

xingfudeshi
Copy link
Member

@xingfudeshi xingfudeshi commented Jan 12, 2020

Ⅰ. Describe what this PR did

Fix configuration center cannot read configuration using SpringCloudConfig

Ⅱ. Does this pull request fix one issue?

fixes #2104

Ⅲ. Why don't you add test cases (unit test/integration test)?

I've done integration testing and already added a UT.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@xingfudeshi xingfudeshi added this to the 1.1.0 milestone Jan 12, 2020
@codecov-io
Copy link

codecov-io commented Jan 12, 2020

Codecov Report

Merging #2172 into develop will increase coverage by 1.13%.
The diff coverage is 54.28%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2172      +/-   ##
=============================================
+ Coverage       52.8%   53.93%   +1.13%     
- Complexity      2518     2620     +102     
=============================================
  Files            489      490       +1     
  Lines          15344    15342       -2     
  Branches        1750     1751       +1     
=============================================
+ Hits            8102     8275     +173     
+ Misses          6469     6285     -184     
- Partials         773      782       +9
Impacted Files Coverage Δ Complexity Δ
...ing/boot/autoconfigure/util/StringFormatUtils.java 30.76% <ø> (ø) 4 <0> (ø) ⬇️
...e/properties/registry/RegistryRedisProperties.java 80.95% <100%> (+28.32%) 9 <0> (+5) ⬆️
...ta/spring/boot/autoconfigure/StarterConstants.java 96.42% <100%> (-0.94%) 1 <0> (ø)
...gure/provider/SpringBootConfigurationProvider.java 35.71% <36.36%> (+0.32%) 9 <3> (ø) ⬇️
...ot/autoconfigure/properties/file/RmProperties.java 52.94% <52.94%> (ø) 5 <5> (?)
...ot/autoconfigure/properties/file/TmProperties.java 55.55% <55.55%> (ø) 3 <3> (?)
.../autoconfigure/properties/file/UndoProperties.java 53.84% <66.66%> (+53.84%) 4 <3> (+4) ⬆️
.../autoconfigure/properties/file/LockProperties.java 53.84% <66.66%> (+53.84%) 4 <3> (+4) ⬆️
...server/store/file/FileTransactionStoreManager.java 56.5% <0%> (-0.64%) 29% <0%> (-1%)
...o/seata/server/coordinator/DefaultCoordinator.java 54.35% <0%> (-0.52%) 28% <0%> (-1%)
... and 26 more

@xingfudeshi xingfudeshi changed the title bugfix:merge SpringUtils and SpringContextProvider bugfix: fix configuration center cannot read configuration using SpringCloudConfig Jan 25, 2020
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title bugfix: fix configuration center cannot read configuration using SpringCloudConfig bugfix: fix configuration center can't read configuration using SpringCloudConfig Feb 5, 2020
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 1f22626 into apache:develop Feb 5, 2020
@xingfudeshi xingfudeshi deleted the fix_2104 branch February 5, 2020 07:30
booogu pushed a commit to booogu/seata that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

配置中心使用SpringCloudConfig读取不到配置
6 participants