bugfix: fix direct buffer OOM #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: slievrly <slievrly@163.com>
1 task
Codecov Report
@@ Coverage Diff @@
## develop #2175 +/- ##
=============================================
- Coverage 53.16% 53.14% -0.02%
+ Complexity 2515 2513 -2
=============================================
Files 485 485
Lines 15346 15348 +2
Branches 1770 1770
=============================================
- Hits 8158 8156 -2
- Misses 6403 6406 +3
- Partials 785 786 +1
|
|
This can be useful by using the newest snapshot. |
|
已验证，oom问题已解决 |
3 similar comments
|
已验证，oom问题已解决 |
|
已验证，oom问题已解决 |
|
已验证，oom问题已解决 |
ph3636
approved these changes
Jan 14, 2020
| true, | ||
| WORKER_THREAD_SIZE, | ||
| WORKER_THREAD_SIZE, | ||
| 2048 * 64, |
There was a problem hiding this comment.
[2048 * 64] Is this property set too large, 16 times the default value?
There was a problem hiding this comment.
1.0.0版本的默认配置里面。worker-thread-size为配置。默认为netty的线程数是cpu*2。
0.8.0版本的配置文件里面transport.thread-factory.worker-thread-size=8
netty的内存限制已经超过配置的最大直接内存数。所以1.0.0版本在cpu很多的机器上，缺省配置很快就能复现OOM的bug
去掉这段代码，使用netty缺省的配置和参数。netty根据最大直接内存,chunkSize和maxOrder，计算出有效的nDirectArena和nHeapArena
1 task
|
Do not merge for now, collect more feedback. |
booogu
pushed a commit
to booogu/seata
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: slievrly slievrly@163.com
Ⅰ. Describe what this PR did
bugfix: fix direct buffer OOM
Ⅱ. Does this pull request fix one issue?
fix #2164
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews