-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: optimize configuration item prefix judgment #2182
Conversation
Signed-off-by: slievrly <slievrly@163.com>
Codecov Report
@@ Coverage Diff @@
## develop #2182 +/- ##
=============================================
- Coverage 54.37% 53.14% -1.24%
- Complexity 2469 2515 +46
=============================================
Files 447 485 +38
Lines 14749 15353 +604
Branches 1734 1771 +37
=============================================
+ Hits 8020 8159 +139
- Misses 5968 6409 +441
- Partials 761 785 +24
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
...c/main/java/io/seata/spring/boot/autoconfigure/provider/SpringBootConfigurationProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: slievrly <slievrly@163.com> # Conflicts: # seata-spring-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/provider/SpringBootConfigurationProvider.java
Signed-off-by: slievrly <slievrly@163.com> # Conflicts: # seata-spring-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/provider/SpringBootConfigurationProvider.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for new changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: slievrly slievrly@163.com
Ⅰ. Describe what this PR did
optimize: optimize configuration item prefix judgment
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews