Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize configuration item prefix judgment #2182

Merged
merged 7 commits into from
Jan 22, 2020
Merged

optimize: optimize configuration item prefix judgment #2182

merged 7 commits into from
Jan 22, 2020

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

optimize: optimize configuration item prefix judgment

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Jan 14, 2020

Codecov Report

Merging #2182 into develop will decrease coverage by 1.23%.
The diff coverage is 42.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2182      +/-   ##
=============================================
- Coverage      54.37%   53.14%   -1.24%     
- Complexity      2469     2515      +46     
=============================================
  Files            447      485      +38     
  Lines          14749    15353     +604     
  Branches        1734     1771      +37     
=============================================
+ Hits            8020     8159     +139     
- Misses          5968     6409     +441     
- Partials         761      785      +24
Impacted Files Coverage Δ Complexity Δ
.../rm/datasource/undo/mysql/MySQLUndoLogManager.java 82.35% <ø> (ø) 7 <0> (ø) ⬇️
...ava/io/seata/core/constants/ConfigurationKeys.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../seata/rm/datasource/undo/UndoExecutorFactory.java 75% <ø> (+2.77%) 3 <0> (-1) ⬇️
...a/io/seata/discovery/registry/RegistryFactory.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...rc/main/java/io/seata/core/rpc/ChannelManager.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../seata/integration/http/HttpAutoConfiguration.java 0% <0%> (ø) 0 <0> (?)
...o/seata/rm/datasource/AbstractConnectionProxy.java 11.7% <0%> (ø) 5 <0> (ø) ⬇️
...e/src/main/java/io/seata/core/rpc/ChannelUtil.java 0% <0%> (ø) 0 <0> (?)
...ery/registry/consul/ConsulRegistryServiceImpl.java 1.01% <0%> (+0.02%) 1 <0> (ø) ⬇️
...integration/http/HttpHandlerExceptionResolver.java 0% <0%> (ø) 0 <0> (?)
... and 67 more

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Signed-off-by: slievrly <slievrly@163.com>

# Conflicts:
#	seata-spring-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/provider/SpringBootConfigurationProvider.java
Signed-off-by: slievrly <slievrly@163.com>

# Conflicts:
#	seata-spring-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/provider/SpringBootConfigurationProvider.java
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for new changes.

@zjinlei zjinlei closed this Jan 22, 2020
@zjinlei zjinlei reopened this Jan 22, 2020
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 6ba44fb into apache:develop Jan 22, 2020
@slievrly slievrly added this to the 1.1.0 milestone Feb 3, 2020
booogu pushed a commit to booogu/seata that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants