refactor: make seata-config more readable #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2184 +/- ##
=============================================
- Coverage 54.4% 54.39% -0.01%
+ Complexity 2471 2470 -1
=============================================
Files 447 447
Lines 14750 14749 -1
Branches 1734 1734
=============================================
- Hits 8024 8022 -2
Misses 5968 5968
- Partials 758 759 +1
|
zjinlei
reviewed
Jan 15, 2020
config/seata-config-core/src/main/java/io/seata/config/FileConfiguration.java
Outdated
Show resolved
Hide resolved
config/seata-config-etcd3/src/main/java/io/seata/config/etcd3/EtcdConfiguration.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
I found some optimization points when i was reading source code in seata-config module.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews