Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fixed issue of judgement container in kubernetes #2185

Merged
merged 2 commits into from
Jan 16, 2020
Merged

bugfix: fixed issue of judgement container in kubernetes #2185

merged 2 commits into from
Jan 16, 2020

Conversation

helloworlde
Copy link
Contributor

Ⅰ. Describe what this PR did

  1. Fixed issue of judgement container error in older version kubernetes

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jan 15, 2020

Codecov Report

Merging #2185 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2185      +/-   ##
=============================================
- Coverage      54.37%   54.37%   -0.01%     
  Complexity      2469     2469              
=============================================
  Files            447      447              
  Lines          14750    14749       -1     
  Branches        1734     1734              
=============================================
- Hits            8021     8020       -1     
  Misses          5968     5968              
  Partials         761      761
Impacted Files Coverage Δ Complexity Δ
...ain/java/io/seata/config/ConfigurationFactory.java 51.02% <100%> (-0.98%) 3 <0> (ø)

@xingfudeshi xingfudeshi self-requested a review January 16, 2020 01:49
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@guojingyinan219 guojingyinan219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's OK! can judgement container in kubernetes

@slievrly slievrly merged commit a0c08ed into apache:develop Jan 16, 2020
@slievrly slievrly added this to the 1.1.0 milestone Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants