-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix the wrong rollback sequence caused by the same record request from different transaction branches on different servers #2187
Conversation
…uest from different transaction branches on different servers Signed-off-by: slievrly <slievrly@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
script/server/db/mysql.sql
Outdated
PRIMARY KEY (`branch_id`), | ||
KEY `idx_xid` (`xid`) | ||
KEY `idx_xid` (`xid`), | ||
KEY `idx_gmt_create` (`gmt_create`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that the index has no effect on sorting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already remove gmt_create index.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Codecov Report
@@ Coverage Diff @@
## develop #2187 +/- ##
=============================================
+ Coverage 52.88% 53.03% +0.15%
Complexity 2498 2498
=============================================
Files 485 485
Lines 15283 15302 +19
Branches 1715 1754 +39
=============================================
+ Hits 8082 8116 +34
- Misses 6401 6408 +7
+ Partials 800 778 -22
|
Signed-off-by: slievrly <slievrly@163.com>
…to samedata_diffbranch_rollback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…uest from different transaction branches on different servers (apache#2187)
Signed-off-by: slievrly slievrly@163.com
Ⅰ. Describe what this PR did
bugfix: fix the wrong rollback sequence caused by the same record request from different transaction branches on different servers
Ⅱ. Does this pull request fix one issue?
fix #2186
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews