feature: support postgresql(client and server) #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/src/main/java/io/seata/core/store/db/LogStoreSqls.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/SQLVisitorFactory.java # rm-datasource/src/main/java/io/seata/rm/datasource/undo/UndoExecutorFactory.java
# Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/undo/AbstractUndoLogManager.java # rm-datasource/src/main/java/io/seata/rm/datasource/undo/UndoExecutorFactory.java
# Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/undo/KeywordCheckerFactory.java
2.PostgresqlUndoLogManager unsupport "with" 3.BasePostgresqlRecognizer when "o instanceof Null"
use nextval('undo_log_id_seq')
# Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/AsyncWorker.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/cache/PostgresqlTableMetaCache.java # rm-datasource/src/main/java/io/seata/rm/datasource/undo/oracle/OracleUndoLogManager.java # rm-datasource/src/main/java/io/seata/rm/datasource/undo/postgresql/PostgresqlUndoLogManager.java
# Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/AsyncWorker.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/cache/PostgresqlTableMetaCache.java # rm-datasource/src/main/java/io/seata/rm/datasource/undo/oracle/OracleUndoLogManager.java # rm-datasource/src/main/java/io/seata/rm/datasource/undo/postgresql/PostgresqlUndoLogManager.java
slievrly
reviewed
Feb 12, 2020
rm-datasource/src/main/java/io/seata/rm/datasource/AsyncWorker.java
Outdated
Show resolved
Hide resolved
jsbxyyx
reviewed
Feb 12, 2020
...ource/src/main/java/io/seata/rm/datasource/undo/postgresql/PostgresqlUndoDeleteExecutor.java
Show resolved
Hide resolved
...ource/src/main/java/io/seata/rm/datasource/undo/postgresql/PostgresqlUndoInsertExecutor.java
Show resolved
Hide resolved
...ource/src/main/java/io/seata/rm/datasource/undo/postgresql/PostgresqlUndoUpdateExecutor.java
Show resolved
Hide resolved
jsbxyyx
reviewed
Feb 12, 2020
...tasource/src/main/java/io/seata/rm/datasource/sql/struct/cache/PostgresqlTableMetaCache.java
Outdated
Show resolved
Hide resolved
...tasource/src/main/java/io/seata/rm/datasource/sql/struct/cache/PostgresqlTableMetaCache.java
Outdated
Show resolved
Hide resolved
l81893521
approved these changes
Feb 12, 2020
There was a problem hiding this comment.
LGTM. Test passed. Test case below:
Insert:
insert into account_tbl(id, user_id, money) values (?, ?, ?)", id, userId, money)
insert into \"account_tbl\"(id, user_id, money) values (?, ?, ?)", id + 1, userId, money)
Delete:
delete from account_tbl where user_id = ?
delete from "account_tbl" where user_id = ?
delete from account_tbl where user_id in (?)
delete from "account_tbl" where user_id in (?)
delete from account_tbl where id between ? and ?
delete from "account_tbl" where id between ? and ?
Update:
update account_tbl set money = money - ? where user_id = ?
update "account_tbl" set money = money - ? where user_id = ?
update account_tbl set money = money - ? where user_id in (?)
update "account_tbl" set money = money - ? where user_id in (?)
update account_tbl set money = money - ? where user_id between ? and ?
update "account_tbl" set money = money - ? where user_id between ? and ?
Select:
select * from account_tbl where id = ? for update
select * from "account_tbl" where id = ? for update
select * from account_tbl where id in (?) for update
select * from "account_tbl" where id in (?) for update
select * from account_tbl where id between ? and ? for update
select * from "account_tbl" where id between ? and ? for update
jsbxyyx
approved these changes
Feb 12, 2020
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
support PostgreSQL
Ⅱ. Does this pull request fix one issue?
#1279 #1170 #1641 #1972 #1641 #1987 #2143 #2149
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews