-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace getDbType with LoadLevel name #2208
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…older and KeywordChecker and SQLOperateRecognizerHolder with LoadLevel
…older and KeywordChecker and SQLOperateRecognizerHolder with LoadLevel
Codecov Report
@@ Coverage Diff @@
## develop #2208 +/- ##
=============================================
- Coverage 53.04% 52.88% -0.16%
+ Complexity 2500 2498 -2
=============================================
Files 485 485
Lines 15305 15302 -3
Branches 1755 1724 -31
=============================================
- Hits 8118 8093 -25
+ Misses 6411 6407 -4
- Partials 776 802 +26
|
slievrly
reviewed
Jan 20, 2020
rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/TableMetaCacheFactory.java
Show resolved
Hide resolved
slievrly
approved these changes
Jan 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
slievrly
changed the title
refactor: Replace TableMetaCache and UndoLogManager and UndoExecutorHolder and KeywordChecker and SQLOperateRecognizerHolder with LoadLevel
refactor: Replace getDbType with LoadLevel name
Jan 20, 2020
zjinlei
approved these changes
Jan 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: Replace TableMetaCache and UndoLogManager and UndoExecutorHolder and KeywordChecker and SQLOperateRecognizerHolder with LoadLevel