Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace getDbType with LoadLevel name #2208

Merged
merged 6 commits into from
Jan 23, 2020

Conversation

ph3636
Copy link
Contributor

@ph3636 ph3636 commented Jan 19, 2020

refactor: Replace TableMetaCache and UndoLogManager and UndoExecutorHolder and KeywordChecker and SQLOperateRecognizerHolder with LoadLevel

…older and KeywordChecker and SQLOperateRecognizerHolder with LoadLevel
…older and KeywordChecker and SQLOperateRecognizerHolder with LoadLevel
@codecov-io
Copy link

codecov-io commented Jan 19, 2020

Codecov Report

Merging #2208 into develop will decrease coverage by 0.15%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2208      +/-   ##
=============================================
- Coverage      53.04%   52.88%   -0.16%     
+ Complexity      2500     2498       -2     
=============================================
  Files            485      485              
  Lines          15305    15302       -3     
  Branches        1755     1724      -31     
=============================================
- Hits            8118     8093      -25     
+ Misses          6411     6407       -4     
- Partials         776      802      +26
Impacted Files Coverage Δ Complexity Δ
...ava/io/seata/core/constants/ConfigurationKeys.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...eata/core/rpc/netty/AbstractRpcRemotingServer.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ava/io/seata/core/rpc/netty/NettyServerConfig.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...re/properties/registry/ConfigApolloProperties.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...obuf/convertor/BranchRegisterRequestConvertor.java 90.47% <0%> (-9.53%) 3% <0%> (ø)
...otobuf/convertor/GlobalBeginResponseConvertor.java 92.59% <0%> (-7.41%) 3% <0%> (ø)
...otobuf/convertor/GlobalStatusRequestConvertor.java 93.75% <0%> (-6.25%) 3% <0%> (ø)
...otobuf/convertor/GlobalCommitRequestConvertor.java 93.75% <0%> (-6.25%) 3% <0%> (ø)
...obuf/convertor/GlobalRollbackRequestConvertor.java 93.75% <0%> (-6.25%) 3% <0%> (ø)
...protobuf/convertor/RegisterTMRequestConvertor.java 94.73% <0%> (-5.27%) 3% <0%> (ø)
... and 19 more

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title refactor: Replace TableMetaCache and UndoLogManager and UndoExecutorHolder and KeywordChecker and SQLOperateRecognizerHolder with LoadLevel refactor: Replace getDbType with LoadLevel name Jan 20, 2020
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 67a99dd into apache:develop Jan 23, 2020
@zjinlei zjinlei added this to the 1.1.0 milestone Jan 23, 2020
booogu pushed a commit to booogu/seata that referenced this pull request Feb 12, 2020
@ph3636 ph3636 deleted the refactorSPIwithLoadLevel branch March 9, 2020 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants