Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make seata-discovery more readable #2209

Merged
merged 1 commit into from
Jan 20, 2020

Conversation

koonchen
Copy link
Contributor

Ⅰ. Describe what this PR did

I found some optimization points when i was reading source code in seata-discovery module.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jan 20, 2020

Codecov Report

Merging #2209 into develop will increase coverage by <.01%.
The diff coverage is 45.45%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2209      +/-   ##
=============================================
+ Coverage      54.32%   54.33%   +<.01%     
  Complexity      2491     2491              
=============================================
  Files            454      454              
  Lines          14880    14872       -8     
  Branches        1753     1749       -4     
=============================================
- Hits            8084     8081       -3     
+ Misses          6025     6020       -5     
  Partials         771      771
Impacted Files Coverage Δ Complexity Δ
...a/io/seata/discovery/registry/RegistryFactory.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ery/registry/consul/ConsulRegistryServiceImpl.java 1.01% <0%> (+0.02%) 1 <0> (ø) ⬇️
...covery/registry/etcd3/EtcdRegistryServiceImpl.java 11.62% <0%> (+0.17%) 3 <0> (ø) ⬇️
...eata/discovery/loadbalance/LoadBalanceFactory.java 50% <100%> (-16.67%) 1 <1> (ø)
...very/registry/zk/ZookeeperRegisterServiceImpl.java 62.29% <100%> (-0.61%) 24 <3> (ø)

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit b05cecf into apache:develop Jan 20, 2020
@slievrly slievrly added this to the 1.1.0 milestone Feb 3, 2020
booogu pushed a commit to booogu/seata that referenced this pull request Feb 12, 2020
@funky-eyes
Copy link
Contributor

由于前期Seata社区治理规范问题部分代码作者未签署CLA,可能引发社区知识产权风险问题。请所有在Seata社区贡献过代码(包含:主项目、官网、samples和多语言项目等)的 contributor 帮忙在这个链接登录github账号签署相应的开发者CLA,https://cla-assistant.io/seata/seata 。2023.1.31 未签署CLA的代码将会被rewrite,拜托大家帮忙签一下。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants