Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: retry expired commit and rollback globalSession can't be removed #2210

Merged
merged 9 commits into from
Jan 23, 2020
Merged

bugfix: retry expired commit and rollback globalSession can't be removed #2210

merged 9 commits into from
Jan 23, 2020

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Jan 20, 2020

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: retry expired commit and rollback globalSession can't be removed

Ⅱ. Does this pull request fix one issue?

fix #2188

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jan 20, 2020

Codecov Report

Merging #2210 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2210   +/-   ##
==========================================
  Coverage      53.16%   53.16%           
  Complexity      2515     2515           
==========================================
  Files            485      485           
  Lines          15358    15358           
  Branches        1771     1771           
==========================================
  Hits            8165     8165           
  Misses          6409     6409           
  Partials         784      784

@zjinlei zjinlei added this to the 1.1.0 milestone Jan 22, 2020
@zjinlei zjinlei closed this Jan 22, 2020
@zjinlei zjinlei reopened this Jan 22, 2020
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

回滚重试超时没有后没有删除全局事物记录(GlobalSession rollback retry timeout)
4 participants