-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix:fix the value of disableGlobalTransaction not being read correctly #2219
bugfix:fix the value of disableGlobalTransaction not being read correctly #2219
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2219 +/- ##
=============================================
- Coverage 53.15% 53.15% -0.01%
- Complexity 2515 2516 +1
=============================================
Files 485 485
Lines 15360 15362 +2
Branches 1771 1772 +1
=============================================
+ Hits 8165 8166 +1
- Misses 6409 6411 +2
+ Partials 786 785 -1
|
Codecov Report
@@ Coverage Diff @@
## develop #2219 +/- ##
=============================================
- Coverage 53.05% 53.03% -0.02%
+ Complexity 2501 2499 -2
=============================================
Files 485 485
Lines 15304 15304
Branches 1755 1755
=============================================
- Hits 8119 8117 -2
Misses 6409 6409
- Partials 776 778 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -67,9 +67,12 @@ public Object intercept(Object proxy, Method method, Object[] args, MethodProxy | |||
result = get(convertDataId(rawDataId), args[1], (Long) args[2]); | |||
} | |||
if (null != result) { | |||
//If the return type is String,need to convert the object to string | |||
if (method.getReturnType().equals(String.class)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the rest? Such as getBoolean 、 getShort、getInt、getLong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GetConfig converts the values of all configuration items to strings and returns them. Other methods, such as getShort, do not require such a transformation. And Boolean cannot be cast to String.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ⅰ. Describe what this PR did
fix the value of disableGlobalTransaction not being read correctly.
Ⅱ. Does this pull request fix one issue?
fixes #2114
Ⅲ. Why don't you add test cases (unit test/integration test)?
I've done integration testing.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews