Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: ContextCoreLoader.java code style #2224

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

EZKAYOTWJPRKXWCUYEEB
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Feb 4, 2020

Codecov Report

Merging #2224 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2224      +/-   ##
=============================================
- Coverage      53.07%   53.06%   -0.01%     
- Complexity      2501     2502       +1     
=============================================
  Files            485      485              
  Lines          15304    15299       -5     
  Branches        1755     1754       -1     
=============================================
- Hits            8122     8119       -3     
+ Misses          6407     6405       -2     
  Partials         775      775
Impacted Files Coverage Δ Complexity Δ
.../java/io/seata/core/context/ContextCoreLoader.java 100% <100%> (+42.85%) 1 <1> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 56.5% <0%> (-0.96%) 29% <0%> (ø)
.../io/seata/core/context/ThreadLocalContextCore.java 28.57% <0%> (+28.57%) 1% <0%> (+1%) ⬆️

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 8408b76 into apache:develop Feb 4, 2020
@slievrly slievrly added this to the 1.1.0 milestone Feb 4, 2020
booogu pushed a commit to booogu/seata that referenced this pull request Feb 12, 2020
@funky-eyes
Copy link
Contributor

https://cla-assistant.io/seata/seata 请打开cla链接签署,感谢配合

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants