Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: separate tc In/Outbound interface. #2227

Merged
merged 3 commits into from
Feb 6, 2020

Conversation

objcoding
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

Codecov Report

Merging #2227 into develop will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2227      +/-   ##
=============================================
- Coverage      53.94%   53.79%   -0.15%     
  Complexity      2622     2622              
=============================================
  Files            490      490              
  Lines          15346    15346              
  Branches        1751     1721      -30     
=============================================
- Hits            8278     8255      -23     
  Misses          6288     6288              
- Partials         780      803      +23
Impacted Files Coverage Δ Complexity Δ
...obuf/convertor/BranchRegisterRequestConvertor.java 90.47% <0%> (-9.53%) 3% <0%> (ø)
...otobuf/convertor/GlobalBeginResponseConvertor.java 92.59% <0%> (-7.41%) 3% <0%> (ø)
...otobuf/convertor/GlobalStatusRequestConvertor.java 93.75% <0%> (-6.25%) 3% <0%> (ø)
...otobuf/convertor/GlobalCommitRequestConvertor.java 93.75% <0%> (-6.25%) 3% <0%> (ø)
...obuf/convertor/GlobalRollbackRequestConvertor.java 93.75% <0%> (-6.25%) 3% <0%> (ø)
...protobuf/convertor/RegisterTMRequestConvertor.java 94.73% <0%> (-5.27%) 3% <0%> (ø)
...protobuf/convertor/RegisterRMRequestConvertor.java 90.47% <0%> (-4.77%) 3% <0%> (ø)
...tobuf/convertor/BranchReportResponseConvertor.java 95.45% <0%> (-4.55%) 3% <0%> (ø)
...otobuf/convertor/BranchReportRequestConvertor.java 95.45% <0%> (-4.55%) 3% <0%> (ø)
...buf/convertor/BranchRegisterResponseConvertor.java 95.83% <0%> (-4.17%) 3% <0%> (ø)
... and 11 more

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added this to the 1.1.0 milestone Feb 6, 2020
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 21f868d into apache:develop Feb 6, 2020
booogu pushed a commit to booogu/seata that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants