Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix fastjson undo filter tableMeta #2233

Merged
merged 5 commits into from
Feb 9, 2020

Conversation

zjinlei
Copy link
Contributor

@zjinlei zjinlei commented Feb 8, 2020

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #2232

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-io
Copy link

codecov-io commented Feb 9, 2020

Codecov Report

Merging #2233 into develop will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2233      +/-   ##
============================================
+ Coverage      53.63%   53.8%   +0.17%     
- Complexity      2619    2623       +4     
============================================
  Files            491     491              
  Lines          15382   15385       +3     
  Branches        1730    1760      +30     
============================================
+ Hits            8250    8278      +28     
  Misses          6325    6325              
+ Partials         807     782      -25
Impacted Files Coverage Δ Complexity Δ
.../datasource/undo/parser/FastjsonUndoLogParser.java 90% <100%> (+4.28%) 5 <2> (+1) ⬆️
...in/java/io/seata/server/session/GlobalSession.java 84.44% <0%> (+0.44%) 73% <0%> (+1%) ⬆️
...o/seata/server/coordinator/DefaultCoordinator.java 54.87% <0%> (+0.51%) 30% <0%> (+2%) ⬆️
...buf/convertor/BranchRollbackResponseConvertor.java 100% <0%> (+2.94%) 3% <0%> (ø) ⬇️
...tobuf/convertor/BranchCommitResponseConvertor.java 100% <0%> (+3.03%) 3% <0%> (ø) ⬇️
...buf/convertor/GlobalRollbackResponseConvertor.java 100% <0%> (+3.22%) 3% <0%> (ø) ⬇️
...tobuf/convertor/GlobalStatusResponseConvertor.java 100% <0%> (+3.33%) 3% <0%> (ø) ⬇️
...tobuf/convertor/GlobalCommitResponseConvertor.java 100% <0%> (+3.33%) 3% <0%> (ø) ⬇️
...rotobuf/convertor/RegisterRMResponseConvertor.java 82.75% <0%> (+3.44%) 3% <0%> (ø) ⬇️
...rotobuf/convertor/RegisterTMResponseConvertor.java 82.75% <0%> (+3.44%) 3% <0%> (ø) ⬇️
... and 14 more

…ugfix/fastjson/undo/xxx

# Conflicts:
#	rm-datasource/src/main/java/io/seata/rm/datasource/undo/parser/FastjsonUndoLogParser.java
@zjinlei zjinlei changed the title bugfix: fix fastjson undo bugfix: fix fastjson undo filter tableMeta Feb 9, 2020
@zjinlei zjinlei added this to the 1.1.0 milestone Feb 9, 2020
Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 0fa55cb into apache:develop Feb 9, 2020
@zjinlei zjinlei deleted the bugfix/fastjson/undo/xxx branch February 9, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

调用DeleteExecutor.afterImage创建EmptyTableRecords报UnsupportedOperationException
5 participants