Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix type error when fastjson deserialize long type #2234

Merged
merged 2 commits into from
Feb 12, 2020

Conversation

zjinlei
Copy link
Contributor

@zjinlei zjinlei commented Feb 9, 2020

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Feb 9, 2020

Codecov Report

Merging #2234 into develop will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2234      +/-   ##
=============================================
- Coverage      53.77%   53.76%   -0.02%     
- Complexity      2620     2621       +1     
=============================================
  Files            491      491              
  Lines          15389    15393       +4     
  Branches        1762     1765       +3     
=============================================
  Hits            8276     8276              
  Misses          6329     6329              
- Partials         784      788       +4
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/server/session/SessionHolder.java 56.09% <50%> (-2.88%) 17 <1> (ø)

@zjinlei zjinlei added this to the 1.1.0 milestone Feb 9, 2020
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei requested a review from jsbxyyx February 12, 2020 02:19
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit 9981b7c into apache:develop Feb 12, 2020
@zjinlei zjinlei deleted the bugfix/fastjson/undo/long branch February 29, 2020 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants