Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: ApplicationContext has not been refreshed #2261

Merged
merged 4 commits into from
Feb 17, 2020
Merged

bugfix: ApplicationContext has not been refreshed #2261

merged 4 commits into from
Feb 17, 2020

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: ApplicationContext has not been refreshed

Temporary solution, seata-spring-boot-starter is based on spring-boot 1.5, but AnnotationConfigServletWebServerApplicationContext exists in spring-boot 2.0+

Ⅱ. Does this pull request fix one issue?

fix #2260

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

slievrly and others added 3 commits February 17, 2020 18:05
@codecov-io
Copy link

codecov-io commented Feb 17, 2020

Codecov Report

Merging #2261 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2261   +/-   ##
==========================================
  Coverage      50.12%   50.12%           
  Complexity      2664     2664           
==========================================
  Files            518      518           
  Lines          17030    17030           
  Branches        2061     2061           
==========================================
  Hits            8536     8536           
  Misses          7689     7689           
  Partials         805      805

@chengzubin
Copy link

2260已验证OK

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants