Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix nacos script set group error #2262

Merged
merged 2 commits into from
Feb 17, 2020

Conversation

objcoding
Copy link
Contributor

@objcoding objcoding commented Feb 17, 2020

fix #2263

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@objcoding objcoding mentioned this pull request Feb 17, 2020
1 task
@slievrly slievrly changed the title bugfix: fix nacos script. bugfix: fix nacos script set Feb 17, 2020
@slievrly slievrly changed the title bugfix: fix nacos script set bugfix: fix nacos script set group error Feb 17, 2020
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #2262 into develop will increase coverage by 0.02%.
The diff coverage is 31.52%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2262      +/-   ##
=============================================
+ Coverage      50.09%   50.12%   +0.02%     
- Complexity      2662     2664       +2     
=============================================
  Files            518      518              
  Lines          17030    17030              
  Branches        2061     2061              
=============================================
+ Hits            8532     8536       +4     
+ Misses          7691     7689       -2     
+ Partials         807      805       -2
Impacted Files Coverage Δ Complexity Δ
...o/seata/rm/datasource/sql/struct/TableRecords.java 92.85% <ø> (ø) 19 <0> (ø) ⬇️
...ta/spring/annotation/GlobalTransactionScanner.java 52.63% <ø> (ø) 17 <0> (ø) ⬇️
...va/io/seata/core/store/db/LogStoreDataBaseDAO.java 55.92% <ø> (ø) 21 <0> (ø) ⬇️
...a/io/seata/discovery/registry/RegistryService.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ing/annotation/GlobalTransactionalInterceptor.java 10% <ø> (ø) 2 <0> (ø) ⬇️
...java/io/seata/tm/api/DefaultGlobalTransaction.java 70% <ø> (+4.44%) 21 <0> (+2) ⬆️
...a/io/seata/saga/statelang/domain/StateMachine.java 85.71% <ø> (ø) 0 <0> (ø) ⬇️
...main/java/io/seata/core/rpc/netty/RmRpcClient.java 30.76% <ø> (ø) 9 <0> (ø) ⬇️
...a/saga/statelang/domain/impl/StateMachineImpl.java 58.49% <ø> (ø) 20 <0> (ø) ⬇️
...ava/io/seata/core/constants/ConfigurationKeys.java 0% <ø> (ø) 0 <0> (ø) ⬇️
... and 142 more

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit 40f1bbf into apache:develop Feb 17, 2020
@slievrly slievrly added this to the 1.1.0 milestone Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nacos-config.sh error
5 participants