Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix connection context can't be remove when global lock retry #2287

Merged
merged 4 commits into from
Feb 28, 2020
Merged

bugfix: fix connection context can't be remove when global lock retry #2287

merged 4 commits into from
Feb 28, 2020

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: fix connection context can't be remove when global lock conflict

Ⅱ. Does this pull request fix one issue?

fix #2286

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Feb 23, 2020

Codecov Report

Merging #2287 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2287      +/-   ##
=============================================
+ Coverage      51.46%   51.48%   +0.02%     
- Complexity      2664     2667       +3     
=============================================
  Files            511      511              
  Lines          16638    16642       +4     
  Branches        2033     2033              
=============================================
+ Hits            8562     8568       +6     
  Misses          7266     7266              
+ Partials         810      808       -2     
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/server/session/GlobalSession.java 84.44% <0.00%> (+0.44%) 73.00% <0.00%> (+1.00%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 54.87% <0.00%> (+0.51%) 29.00% <0.00%> (+1.00%) ⬇️

@15168326318
Copy link
Contributor

结果测试,这个问题已经修复好了。谢谢!

@slievrly slievrly added this to the 1.2.0 milestone Feb 24, 2020
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei changed the title bugfix: fix connection context can't be remove when global lock conflict bugfix: fix connection context can't be remove when global lock retry Feb 28, 2020
@zjinlei zjinlei merged commit caca398 into apache:develop Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants