Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecov: codecov ignore mock #2288

Merged
merged 5 commits into from
Feb 24, 2020
Merged

Conversation

lovepoem
Copy link
Member

Ⅰ. Describe what this PR did

Codecov ignore mock

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

ci success

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Feb 23, 2020

Codecov Report

Merging #2288 into develop will increase coverage by 1.27%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2288      +/-   ##
=============================================
+ Coverage      50.12%   51.39%   +1.27%     
+ Complexity      2662     2661       -1     
=============================================
  Files            518      510       -8     
  Lines          17033    16604     -429     
  Branches        2063     2033      -30     
=============================================
- Hits            8538     8534       -4     
+ Misses          7687     7261     -426     
- Partials         808      809       +1     
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 56.50% <0.00%> (-1.27%) 29.00% <0.00%> (-1.00%)
...eata/rm/datasource/mock/MockPreparedStatement.java
...va/io/seata/rm/datasource/mock/MockConnection.java
...eata/rm/datasource/mock/MockParameterMetaData.java
...est/java/io/seata/rm/datasource/mock/MockBlob.java
...est/java/io/seata/rm/datasource/mock/MockClob.java
...eata/rm/datasource/mock/MockResultSetMetaData.java
...t/java/io/seata/rm/datasource/mock/MockDriver.java
...ava/io/seata/rm/datasource/mock/MockResultSet.java

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/seata/seata/pull/2288/files#diff-8bc9db6adba7208e25c96be322351063L14 needs to be modified because the codec module has been renamed as serializer.

@lovepoem
Copy link
Member Author

lovepoem commented Feb 23, 2020

https://github.com/seata/seata/pull/2288/files#diff-8bc9db6adba7208e25c96be322351063L14 needs to be modified because the codec module has been renamed as serializer.

image

The generated codes is in target ,I think it doesn't affect coverage , but I will have a try

@slievrly slievrly changed the title Codecov ignore mock codecov: codecov ignore mock Feb 24, 2020
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lovepoem lovepoem merged commit d5fad94 into apache:develop Feb 24, 2020
@slievrly slievrly added this to the 1.2.0 milestone Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants