Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:fix some configuration not converted to camel style #2292

Merged
merged 4 commits into from
Feb 28, 2020
Merged

bugfix:fix some configuration not converted to camel style #2292

merged 4 commits into from
Feb 28, 2020

Conversation

xingfudeshi
Copy link
Member

Ⅰ. Describe what this PR did

This is a small fix for seata1.1.0 since there are some config items need to be corrected.

Ⅱ. Does this pull request fix one issue?

fixes #2291

Ⅲ. Why don't you add test cases (unit test/integration test)?

I've done integration testing.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Feb 24, 2020

Codecov Report

Merging #2292 into develop will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2292   +/-   ##
==========================================
  Coverage      51.47%   51.47%           
- Complexity      2666     2667    +1     
==========================================
  Files            511      511           
  Lines          16638    16638           
  Branches        2033     2033           
==========================================
  Hits            8564     8564           
  Misses          7266     7266           
  Partials         808      808           

@slievrly slievrly added this to the 1.2.0 milestone Feb 24, 2020
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

there are some config items need to be corrected
4 participants