Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: remove duplicated dependency in seate-test module #2297

Merged

Conversation

l81893521
Copy link
Contributor

Ⅰ. Describe what this PR did

spring-jdbc was duplicated in seate-test module.

Ⅱ. Does this pull request fix one issue?

#2296

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Feb 25, 2020

Codecov Report

Merging #2297 into develop will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2297      +/-   ##
=============================================
+ Coverage      51.39%   51.39%   +<.01%     
  Complexity      2661     2661              
=============================================
  Files            510      510              
  Lines          16604    16604              
  Branches        2033     2033              
=============================================
+ Hits            8533     8534       +1     
  Misses          7261     7261              
+ Partials         810      809       -1
Impacted Files Coverage Δ Complexity Δ
...obuf/convertor/BranchRegisterRequestConvertor.java 100% <0%> (ø) 3% <0%> (ø) ⬇️
...otobuf/convertor/BranchReportRequestConvertor.java 100% <0%> (ø) 3% <0%> (ø) ⬇️
...obuf/convertor/BranchRollbackRequestConvertor.java 100% <0%> (ø) 3% <0%> (ø) ⬇️
...otobuf/convertor/GlobalBeginResponseConvertor.java 100% <0%> (ø) 3% <0%> (ø) ⬇️
...otobuf/convertor/GlobalStatusRequestConvertor.java 100% <0%> (ø) 3% <0%> (ø) ⬇️
...otobuf/convertor/GlobalCommitRequestConvertor.java 100% <0%> (ø) 3% <0%> (ø) ⬇️
...obuf/convertor/GlobalRollbackRequestConvertor.java 100% <0%> (ø) 3% <0%> (ø) ⬇️
...protobuf/convertor/RegisterTMRequestConvertor.java 100% <0%> (ø) 3% <0%> (ø) ⬇️
...protobuf/convertor/RegisterRMRequestConvertor.java 95.23% <0%> (ø) 3% <0%> (ø) ⬇️
...tobuf/convertor/BranchReportResponseConvertor.java 100% <0%> (ø) 3% <0%> (ø) ⬇️
... and 20 more

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 46f0b03 into apache:develop Feb 26, 2020
@slievrly slievrly added this to the 1.2.0 milestone Mar 15, 2020
@l81893521 l81893521 deleted the fix_spring_jdbc_duplicated_dependency branch April 10, 2020 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants