feature: postgresql add default expr and nextval #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2301 +/- ##
=============================================
- Coverage 51.41% 51.32% -0.09%
+ Complexity 2807 2803 -4
=============================================
Files 553 553
Lines 17698 17716 +18
Branches 2093 2097 +4
=============================================
- Hits 9099 9093 -6
- Misses 7742 7763 +21
- Partials 857 860 +3
|
jaspercloud
reviewed
Apr 6, 2020
...rser-druid/src/main/java/io/seata/sqlparser/druid/postgresql/PostgresqlInsertRecognizer.java
Show resolved
Hide resolved
l81893521
reviewed
Apr 15, 2020
| @@ -0,0 +1,42 @@ | |||
| /* | |||
There was a problem hiding this comment.
why not use com.alibaba.druid.sql.ast.expr.SQLSequenceExpr
There was a problem hiding this comment.
sqlparser module can be multi implemention. druid just one of them.
l81893521
reviewed
Apr 16, 2020
rm-datasource/src/main/java/io/seata/rm/datasource/exec/InsertExecutor.java
Outdated
Show resolved
Hide resolved
l81893521
reviewed
Apr 16, 2020
rm-datasource/src/main/java/io/seata/rm/datasource/exec/InsertExecutor.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Apr 16, 2020
l81893521
approved these changes
Apr 16, 2020
There was a problem hiding this comment.
LGTM. Test case:
PG
insert into account_tbl(id, user_id, money) values (nextval('seq_account_tbl_id'), trim(both ?), ?)
insert into account_tbl(user_id, money, id) values (trim(both ?), ?, nextval('seq_account_tbl_id'))
insert into account_tbl(id, user_id, money) values (default, ?, ?)
Oracle
insert into account_tbl(id, user_id, money, information, description) values (account_tbl_seq.nextval, ?, ?, ?, ?)
|
default as value check valid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
feature: postgresql add default expr and convert nextval to sequence expr.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews