Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Timestamp deserialize lost nano #2309

Merged
merged 3 commits into from
Feb 28, 2020
Merged

bugfix: Timestamp deserialize lost nano #2309

merged 3 commits into from
Feb 28, 2020

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Feb 26, 2020

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: Timestamp deserialize lost nano

fix use kyro and protostuff deserialize lost nano
add UT for timestamp

Ⅱ. Does this pull request fix one issue?

fix #2303

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Feb 26, 2020

Codecov Report

Merging #2309 into develop will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2309      +/-   ##
=============================================
+ Coverage      51.41%   51.47%   +0.06%     
- Complexity      2664     2666       +2     
=============================================
  Files            511      511              
  Lines          16627    16638      +11     
  Branches        2033     2033              
=============================================
+ Hits            8548     8564      +16     
+ Misses          7269     7266       -3     
+ Partials         810      808       -2     
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/server/session/GlobalSession.java 84.44% <0.00%> (+0.44%) 73.00% <0.00%> (+1.00%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 54.87% <0.00%> (+0.51%) 29.00% <0.00%> (+1.00%) ⬇️

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsbxyyx jsbxyyx merged commit b317390 into apache:develop Feb 28, 2020
@slievrly slievrly added this to the 1.2.0 milestone Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serialize timestamp bug
4 participants