Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: protostuff and kryo serialize timestamp #2320

Merged
merged 8 commits into from
Mar 11, 2020
Merged

optimize: protostuff and kryo serialize timestamp #2320

merged 8 commits into from
Mar 11, 2020

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Feb 28, 2020

Ⅰ. Describe what this PR did

optimize protostuff and kryo serialize timestamp.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Feb 28, 2020

Codecov Report

Merging #2320 into develop will increase coverage by 0.03%.
The diff coverage is 88.23%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2320      +/-   ##
=============================================
+ Coverage      51.75%   51.78%   +0.03%     
- Complexity      2696     2697       +1     
=============================================
  Files            517      517              
  Lines          16760    16767       +7     
  Branches        2034     2034              
=============================================
+ Hits            8674     8683       +9     
  Misses          7275     7275              
+ Partials         811      809       -2
Impacted Files Coverage Δ Complexity Δ
.../datasource/undo/parser/KryoSerializerFactory.java 67.5% <100%> (ø) 6 <0> (ø) ⬇️
...atasource/undo/parser/ProtostuffUndoLogParser.java 59.32% <84.61%> (+5.47%) 5 <0> (ø) ⬇️
...java/io/seata/tm/api/DefaultGlobalTransaction.java 74.15% <0%> (-0.29%) 21% <0%> (-1%)
...in/java/io/seata/tm/api/TransactionalTemplate.java 66.97% <0%> (+0.3%) 24% <0%> (ø) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 84.44% <0%> (+0.44%) 73% <0%> (+1%) ⬆️
...o/seata/server/coordinator/DefaultCoordinator.java 54.87% <0%> (+0.51%) 29% <0%> (+1%) ⬆️

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit c277984 into apache:develop Mar 11, 2020
@slievrly slievrly added this to the 1.2.0 milestone Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants