Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize:remove redundant configuration #2348

Merged
merged 2 commits into from
Mar 4, 2020

Conversation

funky-eyes
Copy link
Contributor

Ⅰ. Describe what this PR did

remove redundant configuration

@zjinlei
Copy link
Contributor

zjinlei commented Mar 4, 2020

io.seata.spring.boot.autoconfigure.properties.registry is also required

@codecov-io
Copy link

codecov-io commented Mar 4, 2020

Codecov Report

Merging #2348 into develop will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2348      +/-   ##
=============================================
+ Coverage      51.62%   51.62%   +<.01%     
+ Complexity      2693     2686       -7     
=============================================
  Files            517      517              
  Lines          16728    16700      -28     
  Branches        2038     2038              
=============================================
- Hits            8636     8622      -14     
+ Misses          7284     7270      -14     
  Partials         808      808
Impacted Files Coverage Δ Complexity Δ
.../properties/registry/RegistryEurekaProperties.java 55.55% <ø> (+1.7%) 3 <0> (-1) ⬇️
.../properties/registry/RegistryConsulProperties.java 60% <ø> (+4.44%) 2 <0> (-1) ⬇️
...e/properties/registry/RegistryRedisProperties.java 88.23% <ø> (+7.28%) 8 <0> (-1) ⬇️
...e/properties/registry/RegistryNacosProperties.java 55.55% <ø> (+1.7%) 3 <0> (-1) ⬇️
...operties/registry/RegistryZooKeeperProperties.java 42.85% <ø> (-1.15%) 4 <0> (-1)
...e/properties/registry/RegistryEtcd3Properties.java 60% <ø> (+4.44%) 2 <0> (-1) ⬇️
...re/properties/registry/RegistrySofaProperties.java 52% <ø> (+0.27%) 7 <0> (-1) ⬇️

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 0d35ee1 into apache:develop Mar 4, 2020
funky-eyes added a commit to funky-eyes/seata that referenced this pull request Mar 5, 2020
optimize:remove redundant configuration (apache#2348)
@slievrly slievrly added this to the 1.2.0 milestone Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants