Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: insert sql primary key value support type. #2349

Merged
merged 12 commits into from
Mar 31, 2020
Merged

bugfix: insert sql primary key value support type. #2349

merged 12 commits into from
Mar 31, 2020

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Mar 4, 2020

Ⅰ. Describe what this PR did

insert sql primary key value support type.

Ⅱ. Does this pull request fix one issue?

fixes #2347

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Mar 4, 2020

Codecov Report

Merging #2349 into develop will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2349      +/-   ##
=============================================
+ Coverage      51.45%   51.52%   +0.07%     
- Complexity      2657     2667      +10     
=============================================
  Files            523      523              
  Lines          16940    16944       +4     
  Branches        2052     2053       +1     
=============================================
+ Hits            8716     8731      +15     
+ Misses          7393     7388       -5     
+ Partials         831      825       -6     
Impacted Files Coverage Δ Complexity Δ
...va/io/seata/rm/datasource/exec/InsertExecutor.java 69.87% <100.00%> (+4.44%) 47.00 <15.00> (+8.00)
...in/java/io/seata/server/session/GlobalSession.java 85.77% <0.00%> (+0.45%) 72.00% <0.00%> (+1.00%)
...o/seata/server/coordinator/DefaultCoordinator.java 54.59% <0.00%> (+0.51%) 29.00% <0.00%> (+1.00%)
...torage/file/store/FileTransactionStoreManager.java 57.46% <0.00%> (+0.95%) 29.00% <0.00%> (ø%)

@zjinlei zjinlei added this to the 1.2.0 milestone Mar 12, 2020
@zjinlei zjinlei added the bug label Mar 29, 2020
@slievrly
Copy link
Member

当values中只有一个(one), 多个(more), O表示支持 X表示不支持
null 一个和多个都支持
value 一个和多个都支持
method 一个和多个都不支持
sequence 一个支持,多个不支持

第二个表,表示多个
values中既有纵向和横向值
null, null 支持
null, value 不支持
null, method 不支持
null, sequence 不支持

value, null 不支持
value, value 支持
value, method 不支持
value, sequence 不支持

method, null 不支持
method, value 不支持
method, method 不支持
method, sequence 不支持

sequence, null 不支持
sequence, value 不支持
sequence, method 不支持
sequence, sequence 不支持

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. And I believe that we could support "value" "null" "sequence" at the same time later.
Test case:

id=1
insert into account_tbl(id, user_id, money, information) values (?, ?, ?, ?)
insert into account_tbl(id, user_id, money, information) values (?, ?, ?, ?), (?, ?, ?, ?)
id=null
insert into account_tbl(id, user_id, money, information) values (?, ?, ?, ?), (?, ?, ?, ?)

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit b71d84e into apache:develop Mar 31, 2020
@wangliang181230 wangliang181230 added type: bug Category issues or prs related to bug. and removed bug labels Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seata At 添加语句主键使用uuid()函数异常
6 participants