feature: support propagation.never, propagation.mandatory, transaction suspend and resume api #2359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightClouds917
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #2359 +/- ##
=============================================
- Coverage 51.75% 51.73% -0.02%
- Complexity 2697 2702 +5
=============================================
Files 517 518 +1
Lines 16788 16819 +31
Branches 2030 2035 +5
=============================================
+ Hits 8688 8701 +13
- Misses 7289 7306 +17
- Partials 811 812 +1
|
|
@CharmingRabbit @zjinlei PTAL |
zjinlei
reviewed
Mar 6, 2020
LGTM. |
|
I created a new class SuspendedResourcesHolder,Can be used to temporarily save transaction state for later recovery,when we suspend global transaction ,or change the branchType, Or handle other nesting situations later. |
|
@zjinlei @CharmingRabbit @a364176773 PTAL,THS |
|
@zjinlei @CharmingRabbit @a364176773 PTAL,THS |
slievrly
reviewed
Mar 20, 2020
| return business.execute(); | ||
| } | ||
| break; | ||
| case REQUIRED: | ||
| break; | ||
| case NEVER: | ||
| if (existingTransaction()) { | ||
| throw new TransactionException("Existing transaction found for transaction marked with propagation 'never'"); |
There was a problem hiding this comment.
ok，i will add now
slievrly
changed the title
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
1.add propagation about:never,mandatory；
2.optimize the transationTemplate code；
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews