Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize:add zk missing configuration #2368

Merged
merged 8 commits into from
Mar 16, 2020
Merged

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Mar 6, 2020

Ⅰ. Describe what this PR did

server zookeeper digest support

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes changed the title bugfix:server added zk configuration bugfix:server zookeeper digest support Mar 6, 2020
@funky-eyes funky-eyes changed the title bugfix:server zookeeper digest support feature:server zookeeper digest support Mar 6, 2020
@codecov-io
Copy link

codecov-io commented Mar 6, 2020

Codecov Report

Merging #2368 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2368      +/-   ##
=============================================
+ Coverage      51.79%   51.82%   +0.02%     
  Complexity      2696     2696              
=============================================
  Files            517      517              
  Lines          16761    16761              
  Branches        2028     2028              
=============================================
+ Hits            8682     8686       +4     
+ Misses          7267     7265       -2     
+ Partials         812      810       -2     
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 57.46% <0.00%> (+1.26%) 29.00% <0.00%> (ø%)

Copy link
Contributor

@objcoding objcoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor Author

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@funky-eyes funky-eyes changed the title feature:server zookeeper digest support feature:add zk missing configuration Mar 8, 2020
@funky-eyes funky-eyes changed the title feature:add zk missing configuration supplement:add zk missing configuration Mar 9, 2020
@xingfudeshi xingfudeshi self-requested a review March 9, 2020 12:42
@xingfudeshi xingfudeshi changed the title supplement:add zk missing configuration optimize:add zk missing configuration Mar 9, 2020
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei added this to the 1.2.0 milestone Mar 12, 2020
@slievrly slievrly merged commit 8c74198 into apache:develop Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants